Conversation
sxlijin
temporarily deployed
to
boundary-tools-dev
GitHub Actions
Inactive
sxlijin
temporarily deployed
to
boundary-tools-dev
GitHub Actions
Inactive
sxlijin
temporarily deployed
to
boundary-tools-dev
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
LGTM 👍 |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to e250f7b in 53 seconds. Click for details.
- Reviewed
30lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/build-python-release.reusable.yaml:137
- Draft comment:
Removed pinned maturin version. Unpinning may expose builds to unexpected changes in maturin; ensure that defaults are compatible with your build. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. engine/language_client_python/pyproject.toml:10
- Draft comment:
Updated license configuration: using a simple license string instead of [project.license] with a file reference. Confirm this change meets packaging requirements. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_1ULpL3ChZWk0fesC
You can customize 
|
🌿 Preview your docs: https://boundary-preview-23a2e619-396d-4cbd-8ae8-a94e5a500ad2.docs.buildwithfern.com |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See PyO3/maturin#2718