Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 WalkthroughWalkthroughThe PR adds VM-yielding support for native calls and Array.map, introduces a CPS-style NativeCallResult/Continuation flow, updates codegen/extraction to propagate a new Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Caller as JS/BAML Code
participant VM as BexVm
participant Native as NativeFunction Glue
participant Continuation as Continuation (Rust)
Caller->>VM: call native function (args)
VM->>Native: invoke __glue_{fn}(vm, args)
alt non-yielding
Native-->>VM: NativeCallResult.Done(value)
VM-->>Caller: return value
else yielding
Native-->>VM: NativeCallResult::YieldToCall { callee, args, continuation }
VM->>VM: push NativeFrame(callee, continuation)
VM->>Native: execute callee (possibly bytecode/native)
Note right of VM: callee eventually returns a Value (or Error/Yield)
VM->>Continuation: continuation.call(vm, returned_value)
Continuation-->>VM: NativeCallResult.Done(final_value) or Error or YieldToCall
VM-->>Caller: final_value (or propagate Error / handle further Yield)
end
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
baml_language/crates/baml_builtins2_codegen/src/extract.rs (1)
200-204: Error message should mention//baml:mut_selfas an alternative.The assertion correctly allows
has_mut_vm || is_mut, but the error message only mentions//baml:mut_vm. For completeness, consider updating the message to reflect that//baml:mut_selfalso satisfies the requirement for methods.📝 Suggested message improvement
assert!( !may_yield || has_mut_vm || is_mut, - "baml codegen error: {path} has //baml:may_yield without //baml:mut_vm \ - -- yielding methods require mutable VM access" + "baml codegen error: {path} has //baml:may_yield without //baml:mut_vm or //baml:mut_self \ + -- yielding methods require mutable VM access" );🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@baml_language/crates/baml_builtins2_codegen/src/extract.rs` around lines 200 - 204, The assert checking may_yield vs. has_mut_vm || is_mut should have its error string updated to mention both accepted annotations; change the assertion message in the assert(...) that references may_yield, has_mut_vm, and is_mut so it lists both //baml:mut_vm and //baml:mut_self as valid ways to obtain mutable access (e.g., "... requires mutable VM access via //baml:mut_vm or //baml:mut_self"). Ensure the message still includes the {path} interpolation and the existing explanatory text.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@baml_language/crates/bex_vm/src/vm.rs`:
- Around line 1379-1426: The YieldToCall branch currently constructs Native and
Bytecode frames by hand (pushing Frame::Native, Frame::Bytecode, calling
allocate_real_locals_for_frame and load_function) which bypasses the invariants
enforced by execute_call_from_locals_offset(); fix by routing this path through
the same call-setup logic (either call execute_call_from_locals_offset() or
extract a helper that mirrors it) instead of manual pushes: validate
callback_args.len() against the callee arity, reject non-FunctionKind::Bytecode
callees, enforce the MAX_FRAMES extra-frame budget, perform the traced-call
bookkeeping and emit SpanNotify::FunctionEnter when appropriate, then set
frame_idx and call load_function/allocate_real_locals_for_frame via that helper
rather than duplicating the frame pushes in the YieldToCall branch.
---
Nitpick comments:
In `@baml_language/crates/baml_builtins2_codegen/src/extract.rs`:
- Around line 200-204: The assert checking may_yield vs. has_mut_vm || is_mut
should have its error string updated to mention both accepted annotations;
change the assertion message in the assert(...) that references may_yield,
has_mut_vm, and is_mut so it lists both //baml:mut_vm and //baml:mut_self as
valid ways to obtain mutable access (e.g., "... requires mutable VM access via
//baml:mut_vm or //baml:mut_self"). Ensure the message still includes the {path}
interpolation and the existing explanatory text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ea65727d-fc38-4fc2-a617-bca95a24c0f2
⛔ Files ignored due to path filters (24)
baml_language/crates/baml_tests/snapshots/__baml_std__/baml_tests____baml_std____03_hir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/__baml_std__/baml_tests____baml_std____04_5_mir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/__baml_std__/baml_tests____baml_std____04_tir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/__baml_std__/baml_tests____baml_std____06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/client_option_types/baml_tests__client_option_types__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/comment_after_string_in_config/baml_tests__comment_after_string_in_config__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/comment_in_type/baml_tests__comment_in_type__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/config_dictionary/baml_tests__config_dictionary__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/config_model_string/baml_tests__config_model_string__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/control_flow/baml_tests__control_flow__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/format_checks/baml_tests__format_checks__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/header_in_llm_function/baml_tests__header_in_llm_function__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__01_lexer__lambda_advanced.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__02_parser__lambda_advanced.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__03_hir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__04_5_mir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__04_tir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__10_formatter__lambda_advanced.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/o1_allowed_roles/baml_tests__o1_allowed_roles__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/retry_policy/baml_tests__retry_policy__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/src/compiler2_tir/snapshots/baml_tests__compiler2_tir__phase5__snapshot_baml_package_items.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/tests/bytecode_format/snapshots/bytecode_format__bytecode_display_expanded.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/tests/bytecode_format/snapshots/bytecode_format__bytecode_display_expanded_unoptimized.snapis excluded by!**/*.snap
📒 Files selected for processing (11)
baml_language/crates/baml_builtins2/baml_std/baml/containers.bamlbaml_language/crates/baml_builtins2_codegen/src/codegen.rsbaml_language/crates/baml_builtins2_codegen/src/extract.rsbaml_language/crates/baml_builtins2_codegen/src/types.rsbaml_language/crates/baml_tests/projects/lambda_advanced/lambda_advanced.bamlbaml_language/crates/baml_tests/tests/arrays.rsbaml_language/crates/baml_tests/tests/lambdas.rsbaml_language/crates/bex_vm/src/package_baml/array.rsbaml_language/crates/bex_vm/src/package_baml/map.rsbaml_language/crates/bex_vm/src/package_baml/mod.rsbaml_language/crates/bex_vm/src/vm.rs
💤 Files with no reviewable changes (2)
- baml_language/crates/baml_tests/tests/lambdas.rs
- baml_language/crates/baml_tests/projects/lambda_advanced/lambda_advanced.baml
Binary size checks passed✅ 7 passed
Generated by |
2kai2kai2
force-pushed
the
kai/call-from-native-fn
branch
from
f8c4a82 to
8986ed6
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
baml_language/crates/baml_builtins2_codegen/src/codegen.rs (1)
843-935: Add a direct unit test for the yielding codegen path.This branch changes both the emitted trait signature and the glue return plumbing, but the local test suite still only asserts non-yielding output shapes. A small assertion for a
may_yieldbuiltin (for examplebaml.Array.map) would make regressions here much easier to catch before they surface elsewhere. As per coding guidelines,**/*.rs: Prefer writing Rust unit tests over integration tests where possible.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@baml_language/crates/baml_builtins2_codegen/src/codegen.rs` around lines 843 - 935, Add a unit test that covers the yielding codegen path: construct a NativeBuiltin with may_yield = true (e.g., mimic baml.Array.map) and call the codegen functions (emit_trait_method and emit_glue_method) to produce output, then assert the emitted trait method includes "fn {method_name}(vm: &mut BexVm," and the glue contains the yielding-specific plumbing (closure returning Result<NativeCallResult, VmRustFnError>, matching that returns NativeCallResult directly, and the "Err(e) => NativeCallResult::Error(e)" arm). Place the test in the same module as emit_glue_method / emit_trait_method so it can build the NativeBuiltin and call clean_param_list / call_arg_list / emit_arg_extractions_indented as needed; this ensures regressions in the may_yield branch are caught by unit tests.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@baml_language/crates/baml_builtins2_codegen/src/extract.rs`:
- Around line 200-204: The current assert permits may_yield when is_mut
(//baml:mut_self) even if has_mut_vm is false, which creates an unsupported
builtin shape; tighten the invariant so that may_yield implies has_mut_vm by
changing the condition to require has_mut_vm whenever may_yield is set (i.e.
replace the `!may_yield || has_mut_vm || is_mut` check with `!may_yield ||
has_mut_vm`), and update the assertion message to reference that yielding
methods require //baml:mut_vm (use the existing symbols `may_yield`,
`has_mut_vm`, `is_mut`, and `path` to locate and adjust the assert and its
message).
In `@baml_language/crates/bex_vm/src/vm.rs`:
- Around line 3065-3092: The continuation path in NativeCallResult::YieldToCall
can return early after calling execute_call_from_locals_offset (in the block
handling cb_callee/cb_args/cb_cont) and thus skip emitting the previously
captured FunctionExit span; ensure the exit span is always emitted before any
early return by moving the span-exit emission to occur immediately after
execute_call_from_locals_offset returns (or by using a RAII/drop guard) so that
both branches that check self.frames.last() and return (including when
ecflo_result.is_some()) will first emit the FunctionExit; update the code paths
around execute_call_from_locals_offset, the
frames.push(Frame::Native(...))/cb_cont handling, and the branches that return
Ok(...) to call the span-exit emission (or install a guard) so spans remain
balanced when a continuation re-yields.
- Around line 1402-1415: The code pushes a NativeFrame (Frame::Native with
NativeFrame { function: callee_ptr, continuation: cb_cont }) onto self.frames
and extends self.stack with cb_args (using cb_locals =
StackIndex::from_raw(self.stack.len())) before calling
execute_call_from_locals_offset(cb_callee, cb_locals, arg_count, frame_idx,
function), which can return an error and leak that mutated state; update both
trampoline loops to atomically roll back those mutations on any early return by
removing the pushed frame from self.frames and truncating self.stack back to the
original length when execute_call_from_locals_offset returns Err (or otherwise
fails), ensuring you reference the same symbols (self.frames,
Frame::Native/NativeFrame, callee_ptr/cb_cont,
cb_args/cb_locals/StackIndex::from_raw, execute_call_from_locals_offset,
frame_idx, function) so the cleanup mirrors the setup.
---
Nitpick comments:
In `@baml_language/crates/baml_builtins2_codegen/src/codegen.rs`:
- Around line 843-935: Add a unit test that covers the yielding codegen path:
construct a NativeBuiltin with may_yield = true (e.g., mimic baml.Array.map) and
call the codegen functions (emit_trait_method and emit_glue_method) to produce
output, then assert the emitted trait method includes "fn {method_name}(vm: &mut
BexVm," and the glue contains the yielding-specific plumbing (closure returning
Result<NativeCallResult, VmRustFnError>, matching that returns NativeCallResult
directly, and the "Err(e) => NativeCallResult::Error(e)" arm). Place the test in
the same module as emit_glue_method / emit_trait_method so it can build the
NativeBuiltin and call clean_param_list / call_arg_list /
emit_arg_extractions_indented as needed; this ensures regressions in the
may_yield branch are caught by unit tests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ac35c1e6-1ffb-47d1-be9b-fd444214fd44
⛔ Files ignored due to path filters (24)
baml_language/crates/baml_tests/snapshots/__baml_std__/baml_tests____baml_std____03_hir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/__baml_std__/baml_tests____baml_std____04_5_mir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/__baml_std__/baml_tests____baml_std____04_tir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/__baml_std__/baml_tests____baml_std____06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/client_option_types/baml_tests__client_option_types__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/comment_after_string_in_config/baml_tests__comment_after_string_in_config__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/comment_in_type/baml_tests__comment_in_type__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/config_dictionary/baml_tests__config_dictionary__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/config_model_string/baml_tests__config_model_string__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/control_flow/baml_tests__control_flow__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/format_checks/baml_tests__format_checks__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/header_in_llm_function/baml_tests__header_in_llm_function__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__01_lexer__lambda_advanced.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__02_parser__lambda_advanced.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__03_hir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__04_5_mir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__04_tir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__10_formatter__lambda_advanced.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/o1_allowed_roles/baml_tests__o1_allowed_roles__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/retry_policy/baml_tests__retry_policy__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/src/compiler2_tir/snapshots/baml_tests__compiler2_tir__phase5__snapshot_baml_package_items.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/tests/bytecode_format/snapshots/bytecode_format__bytecode_display_expanded.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/tests/bytecode_format/snapshots/bytecode_format__bytecode_display_expanded_unoptimized.snapis excluded by!**/*.snap
📒 Files selected for processing (11)
baml_language/crates/baml_builtins2/baml_std/baml/containers.bamlbaml_language/crates/baml_builtins2_codegen/src/codegen.rsbaml_language/crates/baml_builtins2_codegen/src/extract.rsbaml_language/crates/baml_builtins2_codegen/src/types.rsbaml_language/crates/baml_tests/projects/lambda_advanced/lambda_advanced.bamlbaml_language/crates/baml_tests/tests/arrays.rsbaml_language/crates/baml_tests/tests/lambdas.rsbaml_language/crates/bex_vm/src/package_baml/array.rsbaml_language/crates/bex_vm/src/package_baml/map.rsbaml_language/crates/bex_vm/src/package_baml/mod.rsbaml_language/crates/bex_vm/src/vm.rs
💤 Files with no reviewable changes (2)
- baml_language/crates/baml_tests/tests/lambdas.rs
- baml_language/crates/baml_tests/projects/lambda_advanced/lambda_advanced.baml
🚧 Files skipped from review as they are similar to previous changes (3)
- baml_language/crates/baml_builtins2/baml_std/baml/containers.baml
- baml_language/crates/bex_vm/src/package_baml/map.rs
- baml_language/crates/baml_tests/tests/arrays.rs
Native functions can now yield back to the VM to call more VM functions. This works by returning a function pointer + args to call, as well as a `Continuation` to resume execution of the native function once the VM is done evaluating its callees.
This uses the new ability to call VM functions from native functions. Also deleted `Map.map`
and other improvements
2kai2kai2
force-pushed
the
kai/call-from-native-fn
branch
from
8986ed6 to
f0405d8
Compare
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
baml_language/crates/bex_vm/src/vm.rs (1)
1423-1434:⚠️ Potential issue | 🔴 CriticalRollback the pushed native frame and callback args if callback dispatch setup fails.
execute_call_from_locals_offset()can still reject the yielded callee before a callback frame exists here (bad callee kind, arity mismatch,MAX_FRAMES, etc.). By then both branches have already pushedFrame::Nativeand extendedself.stack, so the error path leaks state;try_unwind_exception()only pops the native frame and never drains those callback args because native frames own no stack slice. Snapshotframes.len()/stack.len()before mutating and truncate them on everyErrbefore unwinding or returning.Also applies to: 1713-1738
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@baml_language/crates/bex_vm/src/vm.rs` around lines 1423 - 1434, Before pushing Frame::Native and extending self.stack with callback_args, snapshot the current frames.len() and stack.len(); then call execute_call_from_locals_offset as before but on any Err ensure you truncate self.frames and self.stack back to those saved lengths (removing the pushed NativeFrame and the appended callback args) before propagating/unwinding. Apply this same snapshot-and-truncate pattern around the other analogous block that constructs NativeFrame/cb_locals and calls execute_call_from_locals_offset (the duplicate mentioned) so no state is leaked when execute_call_from_locals_offset rejects the callee.
🧹 Nitpick comments (1)
baml_language/crates/baml_builtins2_codegen/src/codegen.rs (1)
842-936: Add a focused unit test for themay_yieldgenerator path.This branch changes the generated ABI, but the nearby tests still only assert non-yielding shapes. A direct assertion for
Array.mapreturningNativeCallResultand emitting theResult<NativeCallResult, VmRustFnError>wrapper would make this much harder to regress. Please also runcargo test --liblocally before merge.As per coding guidelines, "Prefer writing Rust unit tests over integration tests where possible" and "Always run
cargo test --libif you changed any Rust code".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@baml_language/crates/baml_builtins2_codegen/src/codegen.rs` around lines 842 - 936, Add a focused unit test that exercises the may_yield branch of emit_glue_method: construct a NativeBuiltin with may_yield = true (e.g., similar to Array.map), call emit_glue_method and assert the generated string contains the expected ABI changes — the glue fn signature returning NativeCallResult (fn __glue_{method_name}(vm: &mut BexVm, args: &[Value]) -> NativeCallResult), the inner closure typed as Result<NativeCallResult, VmRustFnError>, the call to Self::{method_name}(vm, {call_args}) inside that closure, and the match arms Ok(r) => r and Err(e) => NativeCallResult::Error(e); use existing helpers like call_arg_list and emit_arg_extractions_indented to build the input and keep the test as a Rust unit test (not integration), then run cargo test --lib locally before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@baml_language/crates/bex_vm/src/vm.rs`:
- Around line 1423-1434: Before pushing Frame::Native and extending self.stack
with callback_args, snapshot the current frames.len() and stack.len(); then call
execute_call_from_locals_offset as before but on any Err ensure you truncate
self.frames and self.stack back to those saved lengths (removing the pushed
NativeFrame and the appended callback args) before propagating/unwinding. Apply
this same snapshot-and-truncate pattern around the other analogous block that
constructs NativeFrame/cb_locals and calls execute_call_from_locals_offset (the
duplicate mentioned) so no state is leaked when execute_call_from_locals_offset
rejects the callee.
---
Nitpick comments:
In `@baml_language/crates/baml_builtins2_codegen/src/codegen.rs`:
- Around line 842-936: Add a focused unit test that exercises the may_yield
branch of emit_glue_method: construct a NativeBuiltin with may_yield = true
(e.g., similar to Array.map), call emit_glue_method and assert the generated
string contains the expected ABI changes — the glue fn signature returning
NativeCallResult (fn __glue_{method_name}(vm: &mut BexVm, args: &[Value]) ->
NativeCallResult), the inner closure typed as Result<NativeCallResult,
VmRustFnError>, the call to Self::{method_name}(vm, {call_args}) inside that
closure, and the match arms Ok(r) => r and Err(e) => NativeCallResult::Error(e);
use existing helpers like call_arg_list and emit_arg_extractions_indented to
build the input and keep the test as a Rust unit test (not integration), then
run cargo test --lib locally before merging.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 85ce37ba-1a16-4dd5-84fa-34619465afc2
⛔ Files ignored due to path filters (14)
baml_language/crates/baml_tests/snapshots/__baml_std__/baml_tests____baml_std____03_hir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/__baml_std__/baml_tests____baml_std____04_5_mir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/__baml_std__/baml_tests____baml_std____04_tir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/__baml_std__/baml_tests____baml_std____06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__01_lexer__lambda_advanced.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__02_parser__lambda_advanced.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__03_hir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__04_5_mir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__04_tir.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__06_codegen.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/snapshots/lambda_advanced/baml_tests__lambda_advanced__10_formatter__lambda_advanced.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/src/compiler2_tir/snapshots/baml_tests__compiler2_tir__phase5__snapshot_baml_package_items.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/tests/bytecode_format/snapshots/bytecode_format__bytecode_display_expanded.snapis excluded by!**/*.snapbaml_language/crates/baml_tests/tests/bytecode_format/snapshots/bytecode_format__bytecode_display_expanded_unoptimized.snapis excluded by!**/*.snap
📒 Files selected for processing (11)
baml_language/crates/baml_builtins2/baml_std/baml/containers.bamlbaml_language/crates/baml_builtins2_codegen/src/codegen.rsbaml_language/crates/baml_builtins2_codegen/src/extract.rsbaml_language/crates/baml_builtins2_codegen/src/types.rsbaml_language/crates/baml_tests/projects/lambda_advanced/lambda_advanced.bamlbaml_language/crates/baml_tests/tests/arrays.rsbaml_language/crates/baml_tests/tests/lambdas.rsbaml_language/crates/bex_vm/src/package_baml/array.rsbaml_language/crates/bex_vm/src/package_baml/map.rsbaml_language/crates/bex_vm/src/package_baml/mod.rsbaml_language/crates/bex_vm/src/vm.rs
💤 Files with no reviewable changes (2)
- baml_language/crates/baml_tests/tests/lambdas.rs
- baml_language/crates/baml_tests/projects/lambda_advanced/lambda_advanced.baml
🚧 Files skipped from review as they are similar to previous changes (5)
- baml_language/crates/baml_builtins2_codegen/src/types.rs
- baml_language/crates/baml_tests/tests/arrays.rs
- baml_language/crates/baml_builtins2/baml_std/baml/containers.baml
- baml_language/crates/baml_builtins2_codegen/src/extract.rs
- baml_language/crates/bex_vm/src/package_baml/map.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many cases, we need to be able to call a BAML bytecode function from a BAML native function (implemented in Rust). This requires the ability to "pause" execution of the Rust function to yield control back to the VM execution loop. This is implemented as a coroutine.
This works by changing the return type of native functions from
Result<Value, VmRustFnError>to an enum withOk,Err, andYieldToCallvariants. TheYieldToCallvariant contains a function pointer and arguments for the VM to call, along with aContinuation. The VM will add a native function frame to the frame stack which holds thisContinuation. Once the called functions return (and their frames are popped), the VM will execute theContinuation, effectively 'resuming' the native function.Note that to ensure the GC does not collect objects held by the native function (since GC events can take place if async operations happen while the called VM function is being executed), the
Continuationhas methods to get and update GC roots that will report to the GC that these objects are still live, even if not held in the VM stack itself.Also:
Array.mapMap.map,Map.map_keys, andMap.map_valuessince we do not have tuple types yet to properly implement them.Summary by CodeRabbit