Use cmake.exe from path, if it is found there#211
Merged
BrunoLevy merged 1 commit intoBrunoLevy:mainfrom Jan 31, 2025
Merged
Conversation
Owner
|
Oh that's interesting ! |
Contributor
Author
|
Works for me: |
Contributor
Author
|
Also note that these are conflicting:
|
PlathC
added a commit
to PlathC/GraphiteThree
that referenced
this pull request
Feb 13, 2025
BrunoLevy
added a commit
to BrunoLevy/GraphiteThree
that referenced
this pull request
Feb 14, 2025
Propagate PR BrunoLevy/geogram#211
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes
configure.batto usecmake.exefrom path, if it is found there. This makes the script to work on systems that have Visual Studio installed, but no separate installation for CMake for Windows. Opening Developer Command Prompt for VS 2022 brings cmake bundled with Visual Studio into path.I am not proficient with bat scripts, so someone else should verify this is a good change. It works on my machine, but I've only tested the path where
cmake.exeis found from path.