ENH: compute_RVD geogram example, add additional input parameters.#336
Open
antoinecollet5 wants to merge 3 commits intoBrunoLevy:mainfrom
Open
ENH: compute_RVD geogram example, add additional input parameters.#336antoinecollet5 wants to merge 3 commits intoBrunoLevy:mainfrom
antoinecollet5 wants to merge 3 commits intoBrunoLevy:mainfrom
Conversation
…gle_threshold` parameter to change the angle threshold to merge the nearly coplanar boundary faces + RVD_cells:parallel to indicate whether to perform this step in parallel or not. Note that the parallel otpion seems broken for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENH: compute_RVD geogram example, add additional input parameters.
RVD_cells:simplify_boundary_angle_thresholdparameter to change the angle threshold @ which the nearly co-planar boundary faces are merged (until now set to 45° by default).RVD_cells:parallelto indicate whether to perform this step in parallel or not. Note that the parallel option seems broken for now... @BrunoLevy . But that's a first step.