-
Notifications
You must be signed in to change notification settings - Fork 0
overhaul jobby to use sacct #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kopardev
commented
Apr 28, 2025
- refactor: jobby only uses sacct now; removed depencies on dashboard_cli; HPC-agnostic
- refactor: adding tabulate dependency for jobby
|
@kelly-sovacool .. can you update https://ccbr.github.io/Tools/reference/jobby.html#ccbr_tools.jobby for the new jobby? |
FYI that page is generated from the docstrings in |
kelly-sovacool
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I suggested improving how exceptions are captured and raised in several places.
- The regex for nextflow will have to use something like 'TaskHandler[jobId: [0-9]*' to actually capture them.
NOTE: the nextflow test is currently failing until jobby is modified to correctly parse nextflow logs
… into jobby_update_vnk
… into jobby_update_vnk
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 72.77% 70.63% -2.15%
==========================================
Files 21 21
Lines 1561 1539 -22
==========================================
- Hits 1136 1087 -49
- Misses 425 452 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… into jobby_update_vnk
ensure black settings are the same
… into jobby_update_vnk
render quarto before running pre-commit
… into jobby_update_vnk
|
@kelly-sovacool .. what are these |
… into jobby_update_vnk
Code coverage reports. This PR will decrease the overall project coverage by 2%. We could break up the jobby code into more functions and write more unit tests if we wanted to improve that figure. |
e817685 to
941a3aa
Compare

