Skip to content

Conversation

@kopardev
Copy link
Contributor

@kopardev kopardev commented May 19, 2025

Changes

drop columns to keep markdown output less messy

Issues

fixes #82

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Write unit tests for any new features, bug fixes, or other code changes.
  • Update docs if there are any API changes.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kopardev kopardev marked this pull request as ready for review May 19, 2025 18:21
@kopardev kopardev requested a review from kelly-sovacool May 19, 2025 18:21
@kelly-sovacool kelly-sovacool changed the base branch from v0.4 to main May 19, 2025 18:25
@kelly-sovacool
Copy link
Member

  • Please open PRs against main
  • Please use the PR template and fill it out

@kelly-sovacool kelly-sovacool changed the title issue 82 fix(jobby): drop log columns when output is markdown May 19, 2025
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.30%. Comparing base (c481689) to head (679dd40).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   75.32%   75.30%   -0.02%     
==========================================
  Files          25       25              
  Lines        1787     1786       -1     
==========================================
- Hits         1346     1345       -1     
  Misses        441      441              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kelly-sovacool
Copy link
Member

kelly-sovacool commented May 19, 2025

@kopardev Changes I made:

  • Changed the PR to merge into main, not v0.4 (that branch corresponds to the latest v0.4.X release)
  • Added the PR template back in to the PR description and filled it out.
  • Updated the unit test for the new behavior.
  • Updated the docstring to describe the new behavior.
  • Added a line to the changelog to describe this PR.

Copy link
Contributor Author

sure .. will that be v0.4.1?

@kelly-sovacool
Copy link
Member

sure .. will that be v0.4.1?

Whenever we cut a release, the post-release action fast-forwards the branch named for the major & minor version to include that release. So when we release v0.4.1, v0.4 will automatically be updated to point to v0.4.1.

@kelly-sovacool kelly-sovacool merged commit 54466ec into main May 19, 2025
11 checks passed
@kelly-sovacool kelly-sovacool deleted the issue_82 branch May 19, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jobby updates

3 participants