Skip to content

Conversation

@kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented May 30, 2025

Changes

  • Allow pipelines to pass in module versions
    • this is needed for the next version of champagne which will use nextflow v25 for the new output directive, while other pipelines will continue to use the default nextflow module version.
  • Ensure nextflow.run() stops if preview errors

Issues

fixes CCBR/CHAMPAGNE#255

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Write unit tests for any new features, bug fixes, or other code changes.
  • Update docs if there are any API changes.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26%. Comparing base (2789edf) to head (49d7ace).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   75.30%   75.26%   -0.05%     
==========================================
  Files          25       25              
  Lines        1786     1779       -7     
==========================================
- Hits         1345     1339       -6     
+ Misses        441      440       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kelly-sovacool kelly-sovacool marked this pull request as ready for review May 30, 2025 14:34
@kelly-sovacool kelly-sovacool self-assigned this May 30, 2025
@kelly-sovacool kelly-sovacool merged commit bcd0506 into main May 30, 2025
12 checks passed
@kelly-sovacool kelly-sovacool deleted the hpc-modules-override branch May 30, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make sure slurm job is not submitted if preview fails

2 participants