Skip to content

Move the updated_meta_path default assignment to the workflow because global reassignment isn't being recognized#336

Merged
jessicarowell merged 1 commit into
devfrom
335-detect-updated_meta_path
Aug 28, 2025
Merged

Move the updated_meta_path default assignment to the workflow because global reassignment isn't being recognized#336
jessicarowell merged 1 commit into
devfrom
335-detect-updated_meta_path

Conversation

@jessicarowell

Copy link
Copy Markdown
Collaborator

Description

If you run the genbank workflow after biosample_and_sra, and you forget to specify --updated_meta_path, it will default to the one generated by biosample_and_sra (as long as you've provided meta_path.

Checklist

Go Through Checklist Below and Place A ✔️ (X Inside the Box) if Completed

General Checks

  • [] Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out?
    • Does it produce the expected outputs, given the inputs provided?
  • [] Have you conducted proper linting procedures?

    • Numpy formatted docstrings for functions
    • Comments explaining lines of code
    • Consistent and intuitive naming conventions for variables, functions, classes, methods, attributes, and scripts
    • Single empty line between class functions, two lines between non-class functions, and two lines between imports and code body
    • Camel case formatting for class names
  • [] Have you updated existing documentation (README.md, etc.) or created new ones within docs?

CDC Checks

  • [] Did you check for sensitive data, and remove any?
  • [] If you added or modified HTML, did you check that it was 508 compliant?

Are additional approvals needed for this change? If so, please mention them below:

Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below:

@jessicarowell jessicarowell merged commit 4dbe948 into dev Aug 28, 2025
1 check failed
@jessicarowell jessicarowell deleted the 335-detect-updated_meta_path branch August 28, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Internal] [Bug] Pipeline may not be automatically detected updated_meta_path

2 participants