Conversation
pvelesko
force-pushed
the
dynamic-event-pools
branch
3 times, most recently
from
56c8894 to
c62f1c9
Compare
~Event skip nullptr check expand event logging hipEvent Dependency debug move addDependecy .cc logTrace & debug event typo Add null event assertion in createEventShared function
checkCallbacks() inside event monitor bugfix
pvelesko
force-pushed
the
dynamic-event-pools
branch
from
c62f1c9 to
07375a7
Compare
as opposed to using multiple threads for calblacks and event monitoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix event refcounts
Switch to using an event stack for handling events inside an event pool
Event pools now start small and double as needed to prevent generation of many events for small test cases
Get rid of
CallbackEventMonitorand use a single thread to handle all other activities such as event monitoring, callbacks, event pool management (if needed in the future)replace all "Event use after delete" asserts with a new function
isDeletedSanityCheck()which does nothing inRelease. Call this function at every event member function.check.py add
--total-runtime=xoption. Given a number of minutes, run tests once to estimate the runtime and then calculate the--num-triesto fill the time allotted.