Add protobuf exporter include comments option #491
Open
JohannSchramm wants to merge 1 commit intoCOVESA:masterfrom
Open
Add protobuf exporter include comments option #491JohannSchramm wants to merge 1 commit intoCOVESA:masterfrom
JohannSchramm wants to merge 1 commit intoCOVESA:masterfrom
Conversation
JohannSchramm
force-pushed
the
protobuf-desc
branch
4 times, most recently
from
46d7253 to
5767807
Compare
Signed-off-by: Johann Schramm <43448334+JohannSchramm@users.noreply.github.com>
JohannSchramm
force-pushed
the
protobuf-desc
branch
from
5767807 to
3c39ce3
Compare
Collaborator
|
Thank for the PR. Great to see that you have updated tests and documentation. We will follow or normal process, presenting at the VSS meeting at Wednesday and then give people time to review for a week. |
| Media.Played.Source: | ||
| datatype: string | ||
| type: actuator | ||
| allowed: ['UNKNOWN', 'SIRIUS_XM', 'AM', 'FM', 'DAB', 'TV', 'CD', 'DVD', 'AUX', 'USB', 'DISK', 'BLUETOOTH', 'INTERNET', 'VOICE', 'BEEP'] |
Collaborator
There was a problem hiding this comment.
Wouldn't the translation of allowed be using a protobuf enum?
Author
There was a problem hiding this comment.
This PR and these docs represents the current state of the protobuf generator.
However I agree, that would probably be the logical next step to use protobuf enums for this.
I've created an Issue for this: #493
Collaborator
|
MoM:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
--include-commentsflag to the protobuf exporter.If provided, the exporter will now generate matching protobuf comments, built from their respective descriptions and other available data, into the resulting
.proto.My main motivation for this feature was to allow the then further generated target language code to include these comments, especially the description, as well.