Don't throw exception for token error response.#844
Merged
schlenk merged 2 commits intoCZ-NIC:masterfrom Feb 11, 2023
Merged
Conversation
schlenk
approved these changes
Feb 11, 2023
Collaborator
schlenk
left a comment
schlenk
left a comment
There was a problem hiding this comment.
LGTM.
Seems i missed the late conversion to the ErrorResponse type in the parse_response() code that runs only after this block, so the issubclass() failed for this case.
Contributor
Author
|
@schlenk Thanks for the quick response! Any chance of getting this in a patch release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upgrading the
pyoidcdependency from1.4.0to1.5.0in Flask-pyoidc it revealed a breaking API change (by breaking this test): AHttpErrorexception is thrown for token error responses, without any possibility of recovering the error response.This change brings back the behavior in
1.4.0which returns the token error response allowing for further handling.