Skip to content

Pass timeout to all requests#848

Merged
tpazderka merged 1 commit intomasterfrom
bandit-timeouts
Mar 13, 2023
Merged

Pass timeout to all requests#848
tpazderka merged 1 commit intomasterfrom
bandit-timeouts

Conversation

@tpazderka
Copy link
Collaborator

@tpazderka tpazderka commented Mar 10, 2023

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.
  • New code is annotated.
  • Changes are covered by tests.

@tpazderka tpazderka requested a review from schlenk March 10, 2023 09:19
schlenk
schlenk approved these changes Mar 11, 2023
View reviewed changes
Copy link
Collaborator

@schlenk schlenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Some of those requests calls might als benefit from allowing to pass in a verify= parameter, as is done in other places.

@tpazderka
Copy link
Collaborator Author

tpazderka commented Mar 13, 2023

Some of those requests calls might als benefit from allowing to pass in a verify= parameter, as is done in other places.

Noted... will think about it.

@tpazderka tpazderka merged commit 76debd6 into master Mar 13, 2023
@tpazderka tpazderka deleted the bandit-timeouts branch March 13, 2023 13:54
infohash added a commit to infohash/pyoidc that referenced this pull request Jul 2, 2023
@infohash
Squashed commit of the following:
a1829af 
commit 5245dca
Author: tpazderka <tomas.pazderka@nic.cz>
Date:   Tue May 16 19:48:56 2023 +0200

    Fix building of the documentation (CZ-NIC#860)

commit ba65e00
Author: Tomáš Pazderka <tomas.pazderka@nic.cz>
Date:   Mon May 15 09:01:02 2023 +0200

    Prepare 1.6.0 release

commit cfd0b6e
Author: Michael Schlenker <MichaelSchlenker@gmx.net>
Date:   Tue May 2 14:02:37 2023 +0200

    Repair some oauth_examples and get rid of the outdated jquery file (CZ-NIC#857)

    * More cleanup

    * Add oauth_example to quality checks

    Signed-off-by: Michael Schlenker <michael.schlenker@contact-software.com>

    * Update CHANGELOG.md

    ---------

    Signed-off-by: Michael Schlenker <michael.schlenker@contact-software.com>
    Co-authored-by: Michael Schlenker <michael.schlenker@contact-software.com>

commit 444bd68
Merge: 3b1a9c3 433017c
Author: tpazderka <tomas.pazderka@nic.cz>
Date:   Wed Apr 5 13:59:40 2023 +0200

    Merge pull request CZ-NIC#854 from gbip/853_session_state

    Use session_state to backup consumer state if available

commit 433017c
Author: Paul Florence <paul.florence@makina-corpus.com>
Date:   Mon Apr 3 17:37:30 2023 +0200

    Use 'session_state' from an Authentication Response to backup consumer state (if available)

commit 3b1a9c3
Merge: a8454e3 1d46f09
Author: tpazderka <tomas.pazderka@nic.cz>
Date:   Mon Mar 27 09:24:34 2023 +0200

    Merge pull request CZ-NIC#852 from CZ-NIC/851-add-consumer-complete-authn-method

    Add authn_method to Consumer.complete()

commit 1d46f09
Author: Jan Musílek <jan.musilek@nic.cz>
Date:   Thu Mar 23 16:25:48 2023 +0100

    Add authn_method to Consumer.complete()

commit a8454e3
Merge: 559c9c8 a855642
Author: tpazderka <tomas.pazderka@nic.cz>
Date:   Fri Mar 17 13:16:25 2023 +0100

    Merge pull request CZ-NIC#850 from hlin/master

    Correct OpenID Connect Core specification URL in doc

commit a855642
Author: Hypo Lin <hlin@hypo.name>
Date:   Fri Mar 17 18:56:19 2023 +0800

    Correct OpenID Connect Core specification URL in doc

commit 559c9c8
Merge: 76debd6 9670f83
Author: tpazderka <tomas.pazderka@nic.cz>
Date:   Mon Mar 13 16:06:25 2023 +0100

    Merge pull request CZ-NIC#847 from CZ-NIC/use-pydantic

    Improve settings by using pydantic

commit 9670f83
Author: Tomáš Pazderka <tomas.pazderka@nic.cz>
Date:   Mon Feb 20 12:42:46 2023 +0100

    Improve settings by using pydantic

commit 76debd6
Merge: 6f7f893 94d1f99
Author: tpazderka <tomas.pazderka@nic.cz>
Date:   Mon Mar 13 14:54:53 2023 +0100

    Merge pull request CZ-NIC#848 from CZ-NIC/bandit-timeouts

    Pass timeout to all requests

commit 94d1f99
Author: Tomáš Pazderka <tomas.pazderka@nic.cz>
Date:   Fri Mar 10 10:19:00 2023 +0100

    Pass timeout to all requests

commit 6f7f893
Merge: f6c590c 12247bc
Author: tpazderka <tomas.pazderka@nic.cz>
Date:   Mon Feb 20 09:38:17 2023 +0100

    Merge pull request CZ-NIC#846 from CZ-NIC/repo-move

    Fix links after repo move

commit 12247bc
Author: Tomáš Pazderka <tomas.pazderka@nic.cz>
Date:   Fri Feb 17 11:50:41 2023 +0100

    Fix links after repo move

    Close CZ-NIC#845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlenk schlenk schlenk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tpazderka @schlenk