Skip to content

Survival function for Cox Time Varying model#1637

Open
rvdinter wants to merge 3 commits intoCamDavidsonPilon:masterfrom
rvdinter:master
Open

Survival function for Cox Time Varying model#1637
rvdinter wants to merge 3 commits intoCamDavidsonPilon:masterfrom
rvdinter:master

Conversation

@rvdinter
Copy link

I've written a method for getting the survival function until timestep $t$ where $0<t<\tau$. It will not show $S(t)$ for all the way to time of failure $\tau$, as you do not know the covariates at that moment. Adding this function supports with calculation of $\int_0^t S(t)$, needed for determining the optimal replacement time.

@CamDavidsonPilon
Copy link
Owner

Neat, thanks @rvdinter! Are you comfortable writing a test for this too? If so, it would go in test_estimation.py under the TestCoxTimeVaryingFitter class.

@rvdinter
Copy link
Author

@CamDavidsonPilon definitely! I will work on it.

@rvdinter
Copy link
Author

@CamDavidsonPilon just added the tests, let me know if I need to change anything!

@rvdinter
Copy link
Author

@CamDavidsonPilon could you review the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants