Skip to content

[Feature](mluOpSgetrf2): add LU parameter#105

Open
Chuancysun wants to merge 2 commits into
Cambricon:masterfrom
Chuancysun:LU
Open

[Feature](mluOpSgetrf2): add LU parameter#105
Chuancysun wants to merge 2 commits into
Cambricon:masterfrom
Chuancysun:LU

Conversation

@Chuancysun

Copy link
Copy Markdown
Collaborator

add LU parameter

@shunshen93

Copy link
Copy Markdown
Collaborator

Feature: add cholesky parameter #95
仿照这个修改下标题吧

Comment thread mlu_op_test.proto Outdated
}

// param to call Sgetrf2()
message Sgetrf2Param {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgetrf2改成lu吧

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgetrf2改成xgetrf,不是LU

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@Chuancysun Chuancysun changed the title add LU parameter [Feature](mluOpSgetrf2): add LU parameter Nov 20, 2024
Comment thread mlu_op_test.proto

// param to call Sgetrf2()
message Sgetrf2Param {
optional int32 mode =1 [default = 1];

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少inplace的参数

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不支持inplace

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Reference-LAPACK/lapack/blob/master/SRC/dgetrf2.f#L69
getrf这个算子,应该是支持原位修改输入的

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个我们在最初时是做的原位的,但后来对接时需求更改为了非原位的

Comment thread mlu_op_test.proto

// param to call Sgetrf2()
message Sgetrf2Param {
optional int32 mode =1 [default = 1];

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Reference-LAPACK/lapack/blob/master/SRC/dgetrf2.f#L69
getrf这个算子,应该是支持原位修改输入的

Comment thread mlu_op_test.proto
EXPAND = 5;
FFT = 65536;
FFT = 65536;
SGETRF2 = 65537;

@shunshen93 shunshen93 Dec 3, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XGETRF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants