Skip to content

fix: stop avfoundation mp4 writes when paused #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richiemcilroy merged 1 commit into from
Oct 28, 2025
Merged

fix: stop avfoundation mp4 writes when paused #1308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion crates/enc-avfoundation/src/mp4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,13 +452,25 @@ impl MP4Encoder {
return Err(FinishError::NotWriting);
}

let mut finish_timestamp = timestamp;

if let Some(pause_timestamp) = self.pause_timestamp {
finish_timestamp = Some(match finish_timestamp {
Some(ts) => ts.min(pause_timestamp),
None => pause_timestamp,
});
}

let Some(mut most_recent_frame) = self.most_recent_frame.take() else {
warn!("Encoder attempted to finish with no frame");
return Err(FinishError::NoFrames);
};

self.is_paused = false;
self.pause_timestamp = None;

// We extend the video to the provided timestamp if possible
if let Some(timestamp) = timestamp
if let Some(timestamp) = finish_timestamp
&& let Some(diff) = timestamp.checked_sub(most_recent_frame.1)
&& diff > Duration::from_millis(500)
{
Expand Down