Potential fix for code scanning alert no. 7: Workflow does not contain permissions#6128
Merged
Potential fix for code scanning alert no. 7: Workflow does not contain permissions#6128
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6128 +/- ##
==========================================
Coverage 50.00% 50.01%
Complexity 7481 7481
==========================================
Files 722 722
Lines 24100 24100
==========================================
+ Hits 12051 12053 +2
+ Misses 12049 12047 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Catrobat/Catroweb/security/code-scanning/7
In general, the fix is to add an explicit
permissionsblock to the workflow (at the top level or within the specific job) and restrict theGITHUB_TOKENto the minimal scopes required. This prevents the workflow from inheriting overly broad default repository/organization permissions.For this workflow, the
deploy-swagger-uijob needs to push generated static files to GitHub Pages viapeaceiris/actions-gh-pages@v4, which requires write access to repository contents. The simplest, least-disruptive fix is to add a job-levelpermissionsblock underdeploy-swagger-uispecifyingcontents: write. This both satisfies the CodeQL requirement and documents clearly what the token can do. No other permissions (issues, pull requests, etc.) are required based on the shown steps, so they should not be granted.Concretely, in
.github/workflows/deploy_api_spec.yaml, underjobs: > deploy-swagger-ui:, insert:indented to match
runs-on. No additional imports, methods, or external definitions are needed because this is a pure YAML configuration change within the existing workflow file.Suggested fixes powered by Copilot Autofix. Review carefully before merging.