Fix #12775: Change default texture to transparent#13409
Open
gy1016 wants to merge 1 commit into
Open
Conversation
Changed defaultTexture and defaultCubeMap from white [255,255,255,255] to transparent [0,0,0,0] to prevent white flashing during material loading.
Contributor
|
Thank you for the pull request, @gy1016! Welcome to the Cesium community! In order for us to review your PR, please complete the following steps:
Review Pull Request Guidelines to make sure your PR gets accepted quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes #12775 by changing the default texture and cube map from white [255, 255, 255, 255]\ to transparent [0, 0, 0, 0].
Problem
When constructing a new Material, users may see a white flash during material loading. This is because the Update-loop-based image loading model that Material employs causes a brief period where the white default texture is visible.
Solution
Make the default texture transparent instead of white. This way, materials won't flash white into existence before loading.
Files Changed
Testing