Skip to content

Fix "everything passes, travis fails"#7204

Merged
ggetz merged 1 commit intomasterfrom
fix-random-ci-failures
Oct 31, 2018
Merged

Fix "everything passes, travis fails"#7204
ggetz merged 1 commit intomasterfrom
fix-random-ci-failures

Conversation

@mramato
Copy link
Contributor

@mramato mramato commented Oct 30, 2018

  1. buildSandcastle is returning a stream that is passed to Promise.join. That means the promise resolves before the stream is finished. Instead it should be returning a promise created from the stream.

  2. npm pack may be screwed with travis' console leading to random failures, redirect it's output to /dev/null to see if it addresses our random build failures

  3. requirejs was occasionally being killed by travis for using too much memory, reduce concurrency during the build process to prevent this from happening.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants