[bugfix] fix left_depend_ counter bug when element returns error in t…#564
Merged
ChunelFeng merged 1 commit intoChunelFeng:mainfrom Nov 1, 2025
Merged
[bugfix] fix left_depend_ counter bug when element returns error in t…#564ChunelFeng merged 1 commit intoChunelFeng:mainfrom
ChunelFeng merged 1 commit intoChunelFeng:mainfrom
Conversation
…he middle of commonRunAll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commonRunAll：在pipeline执行中途有element return error的情况下，下游未执行的element的left_depend_计数器有可能被做了数次减1、但是并不会被重置。如果接着马上执行下一次process，那么left_depend_的问题就会导致不应该并行的element并行跑起来了。
在出错的情况下，保险起见，我们应该对这条pipeline的所有element做refresh，刷新它们的"中间状态"（为方便后续其他人理解，我们统称left_depend_这类计数器为element的"中间状态"）。