Skip to content

add review skill#257

Merged
alex-clickhouse merged 2 commits intomainfrom
review-skill
Mar 20, 2026
Merged

add review skill#257
alex-clickhouse merged 2 commits intomainfrom
review-skill

Conversation

@alex-clickhouse
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings March 20, 2026 10:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a Claude “review” skill intended to standardize PR reviews for the ClickHouse .NET driver repo, and updates the contributor/agent guidance to point reviewers to that skill.

Changes:

  • Updates PR review guidance in AGENTS.md to reference using a review skill.
  • Adds a new .claude/skills/review/SKILL.md file defining a structured PR review process and expected output format.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
AGENTS.md Replaces the prior reference to .github/copilot-instructions.md with a short directive to use the review skill.
.claude/skills/review/SKILL.md Adds the new “review” skill definition and detailed review/output instructions.

## PR Review Guidelines

Use the guidelines in .github/copilot-instructions.md
Use review skill.
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instruction "Use review skill." is too vague for someone reading AGENTS.md without prior context. Consider linking to the actual skill file (e.g., .claude/skills/review/SKILL.md) and/or briefly stating how to invoke the review skill, otherwise this section no longer provides actionable guidance compared to the previous reference to .github/copilot-instructions.md.

Suggested change
Use review skill.
Use the `review` skill defined in [.claude/skills/review/SKILL.md](.claude/skills/review/SKILL.md) to perform structured PR reviews (see that file for invocation details and prompts).

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@alex-clickhouse alex-clickhouse merged commit 4d0bce5 into main Mar 20, 2026
13 of 16 checks passed
@alex-clickhouse alex-clickhouse deleted the review-skill branch March 20, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants