NotImplementedError from dodola downscale

[brews]

Got funny error from a command. I think the command would have looked like:

downscale "az://scratch/dc6-dev-75bpr/fine-climatology-regrid.zarr" \
    --trainvariable "tasmax" \
    --outvariable "tasmax" \
    --yclimocoarse "az://scratch/foobar/coarse-climatology-regrid.zarr" \
    --yclimofine "az://scratch/foobar/fine-climatology-regrid.zarr" \
    --method "BCSD" \
    --domain_file "az://support/domain.0p25x0p25.zarr" \
    --adjustmentfactors "az://scratch/foobar/downscale-adjustmentfactors.zarr" \
    --out "az://scratch/foobar/biascorrected-downscaled.zarr"

The error from logging:

dc6-dev-n9fqz: Traceback (most recent call last):
dc6-dev-n9fqz:   File "/opt/conda/bin/dodola", line 33, in <module>
dc6-dev-n9fqz:     sys.exit(load_entry_point('dodola', 'console_scripts', 'dodola')())
dc6-dev-n9fqz:   File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1134, in __call__
dc6-dev-n9fqz:     return self.main(*args, **kwargs)
dc6-dev-n9fqz:   File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1059, in main
dc6-dev-n9fqz:     rv = self.invoke(ctx)
dc6-dev-n9fqz:   File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1665, in invoke
dc6-dev-n9fqz:     return _process_result(sub_ctx.command.invoke(sub_ctx))
dc6-dev-n9fqz:   File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1401, in invoke
dc6-dev-n9fqz:     return ctx.invoke(self.callback, **ctx.params)
dc6-dev-n9fqz:   File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 767, in invoke
dc6-dev-n9fqz:     return __callback(*args, **kwargs)
dc6-dev-n9fqz:   File "/opt/dodola/dodola/cli.py", line 150, in downscale
dc6-dev-n9fqz:     services.downscale(
dc6-dev-n9fqz:   File "/opt/dodola/dodola/services.py", line 27, in service_logger
dc6-dev-n9fqz:     func(*args, **kwargs)
dc6-dev-n9fqz:   File "/opt/dodola/dodola/services.py", line 190, in downscale
dc6-dev-n9fqz:     adjustment_factors, downscaled_ds = apply_downscaling(
dc6-dev-n9fqz:   File "/opt/dodola/dodola/core.py", line 193, in apply_downscaling
dc6-dev-n9fqz:     model = SpatialDisaggregator(var=train_variable)
dc6-dev-n9fqz:   File "/opt/conda/lib/python3.9/site-packages/skdownscale/spatial_models/sd.py", line 24, in __init__
dc6-dev-n9fqz:     raise NotImplementedError(
dc6-dev-n9fqz: NotImplementedError: functionality for spatial disaggregation of tasmax has not yet been added

I think this is because trainvariable needs to be either temperature or precipitation and this is a restriction from skdownscale....?

If we need any of the variable parameter(s) vocabulary is limited then this should be in documentation, and I don't think it is?

[brews]

Yo, @dgergel, is this trainvariable name requirement likely to change in skdownscale? I suppose the input variables in the dataset -- "tasmax", "dtr", etc -- need to be named "temperature" and "precipitation" in the input dataset, also, eh?

[dgergel]

Ahh that seems like a poor implementation detail, courtesy of yours truly :-(

I can update that in skdownscale if we think that's a good idea?

[brews]

Yeah, I could see the need for this change BUT, I wrote a workaround and I'm running into other trouble suggesting that I need to blow apart this downscaling step and write/check its smaller components. We talked about this a week or two ago and totally predicted this.

It might be better if we revisit this after I have a running prototype of this rewrite. What do you think, @dgergel ?

[dgergel]

Ugh that sounds gross :( Yeah, it sounds like it makes sense to circle back to this after we've broken down the downscaling into workable steps.