Open
Conversation
…ut (<ProtectedRoute>) and nested routing
… simplified header links, used solidjs's <A> component for navbar links + simplified navbar generation
…), started using authGet and authPost, added minimal projects type
…Form>, <Form.LabelAbove>, <Form.TextInput>, <Modal>, and <Button> components for standardized use
… and adding additional classes
Collaborator
|
As discussed 2/4: need to split this into multiple PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I'm slowly familiarizing myself with the codebase, I started at the frontend to learn how the data flows. I tried to structure the commits so they are easily reversible. Most changes only affect the main project list page and create/edit project menu (did not dive deeper yet).
Breaking changes
tsconfig.jsonenvvariableVITE_API_URLin prod. Dev only needs to be pointed to the API server (e.g., http://localhost:8081)./builder-frontend/src/apisimply call/api/resource/..../builder-frontend/.envwill need to changeVITE_API_URLto just the server path (remove trailing/api).@/components/Project/ProjectDetailswith accompanying import changesOrganization changes
<ProtectedRoute>Used
<ProtectedRoute>as a layout for the main<Route>path"/"to handle checking the auth session and display page layout (if user session is null, show<AuthForm>, otherwise show<Header>and the route outlet)/publicfor static assetsactive/inactiveclass and simplified navbar generation (only need label text and href, browser<a>handles the rest)