Skip to content

London | 26-ITP-May | Raihan Sharif | Sprint 3 | Implement and rewrite#1304

Open
RaihanSharif wants to merge 9 commits into
CodeYourFuture:mainfrom
RaihanSharif:sprint-3-implement-and-rewrite
Open

London | 26-ITP-May | Raihan Sharif | Sprint 3 | Implement and rewrite#1304
RaihanSharif wants to merge 9 commits into
CodeYourFuture:mainfrom
RaihanSharif:sprint-3-implement-and-rewrite

Conversation

@RaihanSharif
Copy link
Copy Markdown

@RaihanSharif RaihanSharif commented May 6, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed as per spec.

@RaihanSharif RaihanSharif added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels May 6, 2026
@RaihanSharif RaihanSharif mentioned this pull request May 6, 2026
Open
cjyuan
cjyuan reviewed May 11, 2026
View reviewed changes
Comment thread Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
Comment thread Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js Outdated
Comment thread Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js Outdated
Comment thread Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 11, 2026
@RaihanSharif
Copy link
Copy Markdown
Author

RaihanSharif commented May 14, 2026

Rewrote all the code as per review.

@RaihanSharif RaihanSharif added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 14, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented May 14, 2026

Changes look good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 14, 2026
@RaihanSharif
Copy link
Copy Markdown
Author

RaihanSharif commented May 14, 2026

Thank you for your reviews, and for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RaihanSharif @cjyuan