Glasgow | 2026-ITP-May | Tuan Nguyen | Sprint 3 | 1-Implement-and-rewrite-test#1309
Open
Jacknguyen4438 wants to merge 9 commits into
Open
Glasgow | 2026-ITP-May | Tuan Nguyen | Sprint 3 | 1-Implement-and-rewrite-test#1309Jacknguyen4438 wants to merge 9 commits into
Jacknguyen4438 wants to merge 9 commits into
Conversation
…e first course work test
…xing the get angle jest test description
Jacknguyen4438
added
📅 Sprint 2
Jacknguyen4438
added
📅 Sprint 3
illicitonion
added
Review in progress
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
LGTM - I'm going to mark this complete, but please check your definition of proper fractions according to my comments :)
| assertEquals(isProperFraction(3, 4), true); | ||
| assertEquals(isProperFraction(5, 10), true); | ||
| assertEquals(isProperFraction(-4, 2), false); | ||
| assertEquals(isProperFraction(-4, 10), false); |
Member
There was a problem hiding this comment.
Are you sure -4/10 isn't a proper fraction?
| test(`should return true when numerator is zero`, () => { | ||
| expect(isProperFraction(0, 1)).toEqual(true); | ||
| }); | ||
| test(`should return false when numerator value is negative `, () => { |
illicitonion
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Hello this is my work and after I check with the May ITP course work. I would like to resubmit for all Sprint 3 course work. If change need to be make please let me know
Questions
No question.