London | 26-ITP-May | Alex Jamshidi | Sprint 3 | Implement and rewrite tests#1318
Open
Alex-Jamshidi wants to merge 4 commits into
Open
Conversation
Alex-Jamshidi
added
📅 Sprint 3
Alex-Jamshidi
changed the title
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
LGTM, a couple of small things to check
| @@ -11,7 +11,7 @@ | |||
| // execute the code to ensure all tests pass. | |||
|
|
|||
| function isProperFraction(numerator, denominator) { | |||
Member
There was a problem hiding this comment.
What about isProperFraction(10, 0)?
Author
There was a problem hiding this comment.
isProperFraction(10, 0) correctly returns false
test had already been written for zero denominator input in 2-is-proper-fraction.test.js
added assertEquals test for (10, 0)
| } | ||
|
|
||
| const value = card.slice(0, -1); | ||
| if (value == 10) { |
Member
There was a problem hiding this comment.
Why do you call this out as a separate case from 2-9?
Author
There was a problem hiding this comment.
there isn't a reason to do this, it can be incorporated below to become 2-10
change made
illicitonion
added
Reviewed
Alex-Jamshidi
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Solutions for Sprint 3 - Implement and rewrite