Convert the existing project to a multi-module project#28
Convert the existing project to a multi-module project#28philliplbryant wants to merge 8 commits intoCol-E:masterfrom
Conversation
| @@ -1,4 +1,4 @@ | |||
| package software.coley.boxfx.demo; | |||
| package software.coley.boxfx.demo.basic; | |||
There was a problem hiding this comment.
I moved the application source code to the basic-demo submodule under demos, from the src/test directory to the src/main directory, and modified the package names to match the module names and path.
The change to the basic-demo submodule under demos was done in anticipation of a second demo for persistence, which is named persistence-demo.
The change from src/test to src/main is for compatibility with the Gradle Application plugin which, by default, does not support running applications from src/test. Rather, it compiles and launches the application using the main source set. This also follows the standard Gradle project layout where src/main contains the primary code that defines the component's functionality, while src/test is reserved for automated tests.
| // These properties are defined in gradle.properties | ||
| group = property("group") as String | ||
| version = property("version") as String | ||
|
|
There was a problem hiding this comment.
The artifact ID will change to the module name, core, also in anticipation of publishing additional artifacts for persistence.
| #****************************************************************************** | ||
|
|
||
| group=software.coley.bentofx | ||
| version=0.15.2-SNAPSHOT |
There was a problem hiding this comment.
Might want to change the version from a snapshot version, or could continue using snapshot version until persistence is complete.
It's also possible to move the group name to one of the precompiled Gradle plugin scripts and the version to the TOML file where the other versions are defined. Let me know if this should be changed.
| # This is an unpublished work of SAIC. | ||
| # Copyright (c) 2026 SAIC. All Rights Reserved. | ||
| #****************************************************************************** | ||
|
|
There was a problem hiding this comment.
Changed the group name. GAVs are updated in README.md
| @@ -2,30 +2,57 @@ | |||
|
|
|||
| A docking system for JavaFX. | |||
|
|
|||
There was a problem hiding this comment.
Added a TOC as the readme grows when adding persistence.
I am still planning to convert Gradle from using the Kotlin DSL to the Groovy DSL but would like to do so after adding the persistence modules (#13), which will follow shortly, and contains multiple Gradle precompiled script plugins and convention plugins. I included this note and some other comments in the pull request description. If this is problematic, can we create an "integration branch" into which all changes related to the persistence work can be incrementally merged until complete? |
|
Propose deleting this in favor of changes aggregated into #29 |
2 participants
Converts the existing project to a multi-module project using the Kotlin DSL for Gradle.
Please note, assuming approval of this pull request and permission to do so in a follow on pull request, I am still planning to convert Gradle from using the Kotlin DSL to the Groovy DSL but would like to do so after adding the persistence modules (#13), which will follow shortly, and contains multiple Gradle precompiled script plugins and convention plugins.
Please this pull request also contains changes for the following issues