present-to all: mark mark as not following on button press#14304
Merged
caolanm merged 1 commit intoCollaboraOnline:mainfrom Feb 7, 2026
Merged
present-to all: mark mark as not following on button press#14304caolanm merged 1 commit intoCollaboraOnline:mainfrom
caolanm merged 1 commit intoCollaboraOnline:mainfrom
Conversation
Contributor
|
cypress error of:
|
caolanm
approved these changes
Feb 3, 2026
Contributor
caolanm
left a comment
caolanm
left a comment
There was a problem hiding this comment.
looks ok in principle, though the cypress test failed
when user navigates slide with keyboard during slideshow mark them as not following if they are follower problem: when follower navigated the slides with keyboard they were not marked as unfollowed so that's why "follow presenter" button would not work Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I9ac443ab21244a4f42fd36cc71c7c41568bfd3de
lpranam
force-pushed
the
presntall_key
branch
from
37be391 to
e552c88
Compare
caolanm
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when user navigates slide with keyboard
during slideshow mark them as not following if
they are follower
problem:
when follower navigated the slides with keyboard
they were not marked as unfollowed so that's why
"follow presenter" button would not work
Change-Id: I9ac443ab21244a4f42fd36cc71c7c41568bfd3de
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay