Focusable img alt attribute in Widget DrawingArea#14310
Open
Focusable img alt attribute in Widget DrawingArea#14310
Conversation
caolanm
approved these changes
Feb 3, 2026
codewithvk
reviewed
Feb 3, 2026
rparth07
force-pushed
the
private/rparth07/focusable-img
branch
from
9bb21e3 to
d59e066
Compare
caolanm
force-pushed
the
private/rparth07/focusable-img
branch
from
d59e066 to
5e946fb
Compare
…wing area - if img is focusable then it should have appropriate alt attribute on it instead of parent container - for decorative images, no need to provide accessible name via img alt attribute or via aria-labelledby or aria-label in parent container Change-Id: I2bd3104621800587f167dd6750638a84d1ad10dd Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com>
Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: I62b3545055ccd5d2a3b5916cc9c2b4e850659116
Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: Ib735dbdc038baa9999826084dae5092a6291f78d
rparth07
force-pushed
the
private/rparth07/focusable-img
branch
from
5e946fb to
5f495f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From recent changes, we have aria-labelledby and alt attribute both in Widget DrawingArea which violates single accessible name rule. This changes will fix this issue. Here is how it works.
We have two types of images.
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay