Skip to content

browser: a11y: change color picker to 24×24 size#14346

Merged
pedropintosilva merged 1 commit intoCollaboraOnline:mainfrom
hcvcastro:pr/main/0A
Feb 12, 2026
Merged

browser: a11y: change color picker to 24×24 size#14346
pedropintosilva merged 1 commit intoCollaboraOnline:mainfrom
hcvcastro:pr/main/0A

Conversation

@hcvcastro
Copy link
Member

Change-Id: Ide38a0260739b5a52b389dde4be83a0099ea5752
Signed-off-by: Henry Castro hcastro@collabora.com

.
Change-Id: Ide38a0260739b5a52b389dde4be83a0099ea5752
Signed-off-by: Henry Castro <hcastro@collabora.com>
@banobepascal
Copy link
Contributor

The changes look fine overall.

However, I’m not sure why we need to increase the size to 24px here, since users who want a larger view can already achieve this by adjusting the browser zoom.

Could you clarify the motivation for this change?

cc @pedropintosilva

@hcvcastro
Copy link
Member Author

Could you clarify the motivation for this change?

It is driven by a customer request/requirement

@github-project-automation github-project-automation bot moved this from To Review to To Test in Collabora Online Feb 9, 2026
@pedropintosilva
Copy link
Contributor

Maybe they look too huge. we could reach the exact same target area by simply increasing the padding, this way visually they remain the same but now easier to actually click on them.

Copy link
Contributor

@pedropintosilva pedropintosilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@github-project-automation github-project-automation bot moved this from To Test to In Progress in Collabora Online Feb 10, 2026
@hcvcastro
Copy link
Member Author

Maybe they look too huge. we could reach the exact same target area by simply increasing the padding, this way visually they remain the same but now easier to actually click on them.

The customer requirement doesn't mention adding padding to the color picker box.

@pedropintosilva pedropintosilva self-requested a review February 12, 2026 13:48
@github-project-automation github-project-automation bot moved this from In Progress to To Test in Collabora Online Feb 12, 2026
@pedropintosilva pedropintosilva merged commit 9d20cb2 into CollaboraOnline:main Feb 12, 2026
14 checks passed
@github-project-automation github-project-automation bot moved this from To Test to Done in Collabora Online Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants