Private/timar/missingimages backport#14622
Open
timar wants to merge 7 commits intodistro/collabora/co-25.04from
Open
Private/timar/missingimages backport#14622timar wants to merge 7 commits intodistro/collabora/co-25.04from
timar wants to merge 7 commits intodistro/collabora/co-25.04from
Conversation
When the core sends toolitem widgets with numeric IDs and no command, the ID gets used as the command name, producing requests for nonexistent icons like lc_1.svg, lc_5.svg, lc_65535.svg. Return empty from getIconNameOfCommand() for pure-numeric names, and handle the empty return in JSDialogBuilder by not creating an <img> element. Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: Ie778d5f916be03d930021e4a032d0f3a864cca0b
OverflowGroup creates IDs like 'overflow-button-save-toptoolbar' which get treated as command names and trigger requests for nonexistent icons. Return empty from getIconNameOfCommand() for names starting with 'overflow-button-'. Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I6aca980da9a40b968c19457feaf48bd904f34a62
Add aliases for action IDs that go through getIconNameOfCommand but have no matching icon file: - exportas-pdf -> exportpdf - exportas-epub -> exportepub - fullscreen-drawing -> presentation Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: Ica6a0ccd690c41c6f2d5b6362fc5bd0640afa783
Copy lc_framedialog.svg and lc_removetableof.svg (light and dark variants) from the core colibre icon theme. Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: Iaab0d1775efcb0756062a4f3c8d67121338ad3cd
These icons use light colors (orange/yellow, light gray) that are already visible on dark backgrounds, so they don't need dark variants. Adding them to commonItems avoids unnecessary 404s in dark mode. Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I2e34d20dc724767e5577d33945266beaea7f647a
These icons use light colors (orange/yellow, light gray) that are already visible on dark backgrounds, so they don't need dark variants. Adding them to commonItems avoids unnecessary 404s in dark mode. Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I2e34d20dc724767e5577d33945266beaea7f647a
Reuse alias mappings from the core colibre icon theme: - endnotedialog -> footnotedialog - updateallindexes -> insertmultiindex - formatframemenu -> framedialog Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I481bc13689bf4f06e73194e0f7389aebe6b8d893
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing images found in coolwsd logs.