fix browser logging endpoint: return proper errors, rename to browser-logging#14623
Open
timar wants to merge 1 commit intodistro/collabora/co-25.04from
Open
fix browser logging endpoint: return proper errors, rename to browser-logging#14623timar wants to merge 1 commit intodistro/collabora/co-25.04from
timar wants to merge 1 commit intodistro/collabora/co-25.04from
Conversation
…-logging The logging.html POST endpoint silently fell through to the static file handler when browser_logging was disabled or the token was invalid, causing spurious "File not found" errors in the logs. Always return an appropriate response: 403 with a reason when disabled or token is wrong, 200 on success. Also rename the endpoint from logging.html to browser-logging to better reflect its purpose. Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I35bcfed4d65fdda06dcb59dd6491ecfa26866a83
timar
force-pushed
the
private/timar/browser-logging-backport
branch
from
6c4a6c1 to
0290f3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logging.html POST endpoint silently fell through to the static file handler when browser_logging was disabled or the token was invalid, causing spurious "File not found" errors in the logs. Always return an appropriate response: 403 with a reason when disabled or token is wrong, 200 on success. Also rename the endpoint from logging.html to browser-logging to better reflect its purpose.