coolwsd restart: expVer is 10 chars long but only 8 chars are expected

[gcoretech]

After updating to nextcloud 30.0.3 today the internal CODE server does not work reliably.

PHP log shows:
[06-Dec-2024 08:19:40 UTC] Old server found, restarting. Expected hash a4b67a7664 but found a4b67a76.

I don't know where COOLWSD_VERSION_HASH is coming from but the comment after $actVer = substr ... says expVer is at most 8 characters long whereas it currently is 10 characters long.

richdocumentscode/proxy.php

Line 273 in 0afd8d9

$expVer = '%COOLWSD_VERSION_HASH%';

The local richdocuments/proxy.php file shows:

        $response = file_get_contents("http://localhost:9983/hosting/capabilities", 0, stream_context_create(["http"=>["timeout"=>1]]));
        if ($response) {
            // Version check.
            $obj = json_decode($response);
            $actVer = substr($obj->{'productVersionHash'}, 0, 8); // expVer is at most 8 characters long
            $expVer = 'a4b67a7664';
            if ($actVer !== $expVer && $expVer !== '%' . 'COOLWSD_VERSION_HASH' . '%') { // deliberately split so that sed does not touch this during build-time
                // Old/unexpected server version; restart.
                error_log("Old server found, restarting. Expected hash $expVer but found $actVer.");
                stopCoolwsd();

[ibot3]

Also have the same problem.

It comes from here:

richdocumentscode/build-nextcloud-app.sh

Line 49 in 315481c

HASH=`./${app_name}/collabora/Collabora_Online.AppImage --version-hash`

I manually checked this and the AppImage does return a 10 char hash.

[ibot3]

They changed the length of the hash here:
CollaboraOnline/online@5dff4d1

So, this line must be changed to not cut the last two chars of the current version hash:

richdocumentscode/proxy.php

Line 272 in 0afd8d9

$actVer = substr($obj->{'productVersionHash'}, 0, 8); // expVer is at most 8 characters long

[sebschue]

To avoid future problems due to the length of the version hash, the following code:

richdocumentscode/proxy.php

Lines 272 to 273 in 0afd8d9

	$actVer = substr($obj->{'productVersionHash'}, 0, 8); // expVer is at most 8 characters long
	$expVer = '%COOLWSD_VERSION_HASH%';

Should be fixed like this:

$expVer = '%COOLWSD_VERSION_HASH%';
$actVer = substr($obj->{'productVersionHash'}, 0, strlen($expVer););

[tpo]

$actVer = substr($obj->{'productVersionHash'}, 0, strlen($expVer););

that should be

$actVer = substr($obj->{'productVersionHash'}, 0, strlen($expVer));

(spurious semicolon! Otherwise: thanks a lot!!! 🙏 )

[timar]

Fixed in 24.4.1103