Lower deployment target and add availability checks to all Combine related code#29
Lower deployment target and add availability checks to all Combine related code#29freak4pc merged 1 commit intoCombineCommunity:masterfrom RonKliffer:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=======================================
Coverage 97.41% 97.41%
=======================================
Files 38 38
Lines 2244 2244
=======================================
Hits 2186 2186
Misses 58 58
Continue to review full report at Codecov.
|
|
Me and @RonKliffer had a discussion around this yesterday, after I've heard this use-case from several people. There are people who actually use Combine in newer portions of their apps, e.g. iOS 11 apps that want to use this dependency with an availability clause. I think it's a valid use-case overall. WDYT @jasdev @jdisho ? |
|
|
||
| import Combine | ||
|
|
||
| @available(iOS 13.0, *) |
There was a problem hiding this comment.
All tests should stay iOS 13 and up. Only the target itself should be iOS 11+
I'm actually not sure it's possible, but worth checking
|
Seems valid case to me too.👌 |
|
Should we do the same thing for SPM? |
freak4pc
left a comment
There was a problem hiding this comment.
Thank you @RonKliffer ! Ran everything locally and this looks good 💯
No description provided.