Skip to content

Make more intermediate values follow the intermediate dtype.#13051

Merged
comfyanonymous merged 1 commit intomasterfrom
temp_pr
Mar 18, 2026
Merged

Make more intermediate values follow the intermediate dtype.#13051
comfyanonymous merged 1 commit intomasterfrom
temp_pr

Conversation

@comfyanonymous
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 592e11c0-af10-481e-961e-b408615fcb11

📥 Commits

Reviewing files that changed from the base of the PR and between b67ed2a and 1f314af.

📒 Files selected for processing (2)
  • comfy/sample.py
  • comfy/sd1_clip.py

📝 Walkthrough

Walkthrough

The changes add explicit data type parameters to tensor transfer operations across two files. In comfy/sample.py, the .to() calls on samples have been updated to include a dtype parameter alongside the device parameter. Similarly, in comfy/sd1_clip.py, all .to() calls in the encode_token_weights function now specify both device and dtype parameters during tensor transfers. These modifications ensure consistent intermediate tensor data type handling without altering function signatures or public APIs.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a description explaining the motivation and impact of enforcing intermediate dtype specifications across these modules.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding explicit dtype parameter to intermediate value transfers in sample.py and sd1_clip.py.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

@comfyanonymous comfyanonymous merged commit dcd6595 into master Mar 18, 2026
16 checks passed
@comfyanonymous comfyanonymous deleted the temp_pr branch March 18, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant