Track custom node startup errors and expose via API endpoint#13184
Draft
Kosinkadink wants to merge 1 commit intomasterfrom
Draft
Track custom node startup errors and expose via API endpoint#13184Kosinkadink wants to merge 1 commit intomasterfrom
Kosinkadink wants to merge 1 commit intomasterfrom
Conversation
Store import and prestartup errors in NODE_STARTUP_ERRORS dict (nodes.py, main.py) and add GET /custom_node_startup_errors endpoint (server.py) so the frontend/Manager can distinguish failed imports from missing nodes. Ref: ComfyUI-Launcher#303 Amp-Thread-ID: https://ampcode.com/threads/T-019d2346-6e6f-75e0-a97f-cdb6e26859f7 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Store import and prestartup errors for custom nodes and expose them via a new API endpoint, so the frontend/Manager can distinguish between a node pack that failed to import vs. one that is simply not installed.
Changes
NODE_STARTUP_ERRORSdict; populated on import failure inload_custom_node()NODE_STARTUP_ERRORSon prestartup script failure inexecute_prestartup_script()GET /custom_node_startup_errorsendpoint returning the error dict as JSONAPI
Ref: Comfy-Org/ComfyUI-Desktop-2.0-Beta#303