Lint: Adding more checks for non internationalized strings#5625
Conversation
🎭 Playwright Test Results⏰ Completed at: 11/25/2025, 05:43:29 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
DrJKL
changed the title
|
SGTM! |
|
I'm not a frontend engineer, so I can't review this change. Claude can do better, haha. |
dosubot
bot
added
the
size:S
## Summary - Fix i18n linting errors by adding missing locale keys to `src/locales/en/main.json` - Update all affected components to use `$t()` for internationalization ## Changes Added the following locale keys: - `comfyOrgLogoAlt`: "ComfyOrg Logo" - `comfy`: "Comfy" - `pressKeysForNewBinding`: "Press keys for new binding" - `defaultBanner`: "default banner" - `enableOrDisablePack`: "Enable or disable pack" - `openManager`: "Open Manager" - `graphNavigation`: "Graph navigation" Updated components to use i18n keys: - `ComfyOrgHeader.vue` - `KeybindingPanel.vue` - `PackBanner.vue` - `PackIcon.vue` - `PackEnableToggle.vue` - `LoadWorkflowWarning.vue` - `SubgraphBreadcrumb.vue` - `SignInContent.vue` ## Test plan - [x] Run `pnpm lint` - all i18n linting errors resolved - [x] Pre-commit hooks pass Aim to make #5625 CI/CD pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6170-bugfix-Fix-i18n-linting-errors-2926d73d365081c3b7fbcbbf4a8e03d6) by [Unito](https://www.unito.io) Co-authored-by: Claude <noreply@anthropic.com>
DrJKL
force-pushed
the
drjkl/i18n-linting
branch
from
aac1538 to
f61ab10
Compare
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/25/2025, 05:35:06 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.18 MB (baseline 3.18 MB) • 🔴 +702 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 940 kB (baseline 940 kB) • 🔴 +214 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 297 kB (baseline 297 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 139 kB (baseline 139 kB) • 🔴 +85 BReusable component library chunks
Status: 6 added / 6 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.84 MB (baseline 3.84 MB) • 🔴 +182 BBundles that do not match a named category
Status: 18 added / 18 removed |
|
we could also fix the failing tests associated with the new rules |
Yeah, I wasn't planning on merging this until they were updated. It was a draft, but @snomiao kicked things off with the other PR |
|
*clicked update branch |
## Summary This PR fixes all @intlify/vue-i18n/no-raw-text linting errors identified in #5625 by replacing raw text strings with proper i18n translation function calls. ## Changes Fixed i18n linting errors in the following files: - `src/components/widget/SampleModelSelector.vue` - "Upload Model" → `$t('g.upload')` - `src/components/topbar/CurrentUserButton.vue` - "user profile" → `$t('g.currentUser')` - `src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue` - "Loading help" → `$t('g.loading')` - `src/components/sidebar/SidebarShortcutsToggleButton.vue` - "shortcuts.shortcuts" → `$t('shortcuts.shortcuts')` - `src/components/sidebar/SidebarLogoutIcon.vue` - "sideToolbar.logout" → `$t('sideToolbar.logout')` - `src/components/sidebar/SidebarHelpCenterIcon.vue` - "menu.help" → `$t('menu.help')` - `src/components/sidebar/SidebarBottomPanelToggleButton.vue` - "sideToolbar.labels.console" → `$t('sideToolbar.labels.console')` - `src/components/load3d/controls/viewer/ViewerCameraControls.vue` - "fov" → `t('load3d.fov')` - `src/components/helpcenter/HelpCenterMenuContent.vue` - "Help Center Menu" and "Recent releases" → `$t()` calls All raw text strings have been replaced with appropriate i18n translation keys that already exist in `src/locales/en/main.json`. ## Related Issue Fixes errors reported in CI job: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/18705105609/job/53341658467?pr=5625 This PR aims to help #5625 pass CI/CD checks. ## Test Plan - All i18n linting errors should be resolved - No functionality changes - only proper use of i18n system - Existing translation keys are used from the locale files ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6280-bugfix-fix-intlify-vue-i18n-no-raw-text-linting-errors-2976d73d365081369b43de01486fb409) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com>
github-actions
bot
removed
the
claude-review
DrJKL
force-pushed
the
drjkl/i18n-linting
branch
from
5a3fa19 to
d975a19
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/platform/cloud/onboarding/CloudSurveyView.vue (1)
83-91: Consider a more semantically appropriate translation key.The
useCaseOtherplaceholder usescloudOnboarding.survey.options.industry.otherPlaceholder, which references "industry" in the key path but is used for a use-case field. While "Please specify" is generic enough to work, using a key that semantically matches the field (or a shared generic key) would be clearer.Consider one of these approaches:
:placeholder=" - $t('cloudOnboarding.survey.options.industry.otherPlaceholder') + $t('cloudOnboarding.survey.options.otherPlaceholder') "Or add a dedicated use-case key to
main.json:"useCase": { "otherPlaceholder": "Please specify" }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
eslint.config.ts(2 hunks)src/components/maskeditor/BrushSettingsPanel.vue(1 hunks)src/components/queue/CompletionSummaryBanner.vue(1 hunks)src/components/widget/SampleModelSelector.vue(3 hunks)src/locales/en/main.json(8 hunks)src/platform/assets/components/AssetGrid.vue(1 hunks)src/platform/assets/components/MediaAssetMoreMenu.vue(6 hunks)src/platform/cloud/onboarding/CloudSurveyView.vue(4 hunks)src/platform/cloud/onboarding/components/CloudLogo.vue(1 hunks)src/renderer/extensions/vueNodes/widgets/components/audio/AudioPreviewPlayer.vue(3 hunks)src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue(1 hunks)src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenuActions.vue(1 hunks)src/workbench/extensions/manager/components/ManagerProgressFooter.vue(2 hunks)tests-ui/tests/components/dialog/footer/ManagerProgressFooter.test.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (9)
- tests-ui/tests/components/dialog/footer/ManagerProgressFooter.test.ts
- src/components/maskeditor/BrushSettingsPanel.vue
- src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenuActions.vue
- src/components/queue/CompletionSummaryBanner.vue
- src/renderer/extensions/vueNodes/widgets/components/audio/AudioPreviewPlayer.vue
- src/platform/assets/components/MediaAssetMoreMenu.vue
- src/workbench/extensions/manager/components/ManagerProgressFooter.vue
- src/components/widget/SampleModelSelector.vue
- eslint.config.ts
🧰 Additional context used
📓 Path-based instructions (12)
**/*.vue
📄 CodeRabbit inference engine (.cursorrules)
**/*.vue: Use setup() function for component logic in Vue 3 Composition API
Utilize ref and reactive for reactive state in Vue 3
Implement computed properties with computed() function
Use watch and watchEffect for side effects in Vue 3
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection in Vue 3
Use Vue 3.5 style of default prop declaration with defineProps()
Organize Vue components in <script> <style> order
Use Tailwind CSS for styling Vue components
Implement responsive design with Tailwind CSS
Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectively
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components in Vue 3
Follow Vue 3 style guide and naming conventions
Never use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage)Never use
:class="[]"to merge class names - always useimport { cn } from '@/utils/tailwindUtil'for class merging in Vue templates
**/*.vue: Use TypeScript with Vue 3 Single File Components (.vuefiles)
Name Vue components in PascalCase (e.g.,MenuHamburger.vue)Files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (.cursorrules)
**/*.{vue,ts,tsx}: Leverage VueUse functions for performance-enhancing utilities
Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.jsonFiles:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue**/*.{ts,tsx,js,vue}
📄 CodeRabbit inference engine (.cursorrules)
Implement proper error handling in components and services
**/*.{ts,tsx,js,vue}: Use 2-space indentation, single quotes, no semicolons, and maintain 80-character line width as configured in.prettierrc
Organize imports by sorting and grouping by plugin, and runpnpm formatbefore committingFiles:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventionsFiles:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonFiles:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue**/*.{ts,tsx,js,jsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
Use camelCase for variable and setting names in TypeScript/Vue files
Files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue**/*.{vue,html}
📄 CodeRabbit inference engine (CLAUDE.md)
Never use
dark:ordark-theme:Tailwind variants - instead use semantic values fromstyle.csstheme, e.g.bg-node-component-surfaceFiles:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,vue}: Useconst settingStore = useSettingStore()andsettingStore.get('Comfy.SomeSetting')to retrieve settings in TypeScript/Vue files
Useawait settingStore.set('Comfy.SomeSetting', newValue)to update settings in TypeScript/Vue files
Check server capabilities usingapi.serverSupportsFeature('feature_name')before using enhanced features
Useapi.getServerFeature('config_name', defaultValue)to retrieve server feature configurationEnforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templates
Files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebaseFiles:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/platform/assets/components/AssetGrid.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.jsonFiles:
src/platform/assets/components/AssetGrid.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue🧠 Learnings (8)
📓 Common learnings
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: AGENTS.md:0-0 Timestamp: 2025-11-24T19:48:23.077Z Learning: Pull requests must pass `pnpm lint`, `pnpm typecheck`, and relevant tests before merging; keep PRs focused and smallLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:34.296Z Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.{vue,ts,tsx} : Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.jsonLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.608Z Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI stringsLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-11-24T19:47:02.828Z Learning: Applies to src/**/*.{vue,ts} : Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: AGENTS.md:0-0 Timestamp: 2025-11-24T19:48:23.077Z Learning: Applies to **/*.{ts,tsx,vue} : Enforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templatesLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.607Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue Chips component with AutoComplete with multiple enabledLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.608Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with MessageLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.vue : Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectivelyLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.607Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitchLearnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:34.296Z Learning: Applies to src/**/*.{ts,tsx,vue} : Implement proper TypeScript types throughout the codebase📚 Learning: 2025-11-24T19:46:52.254Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.{vue,ts,tsx} : Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.jsonApplied to files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vue📚 Learning: 2025-11-24T19:47:45.608Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.608Z Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI stringsApplied to files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue📚 Learning: 2025-11-24T19:47:34.296Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:34.296Z Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`Applied to files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vuesrc/platform/cloud/onboarding/components/CloudLogo.vuesrc/locales/en/main.json📚 Learning: 2025-11-24T19:47:02.828Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-11-24T19:47:02.828Z Learning: Applies to src/**/*.{vue,ts} : Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonApplied to files:
src/platform/assets/components/AssetGrid.vuesrc/platform/cloud/onboarding/CloudSurveyView.vuesrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue📚 Learning: 2025-11-24T19:47:45.607Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.607Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with SelectApplied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue📚 Learning: 2025-11-24T19:46:52.254Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.vue : Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectivelyApplied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue📚 Learning: 2025-11-24T19:46:52.254Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.254Z Learning: Applies to **/*.vue : Never use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage)Applied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: setup
- GitHub Check: collect
- GitHub Check: test
- GitHub Check: lint-and-format
🔇 Additional comments (15)
src/platform/cloud/onboarding/components/CloudLogo.vue (1)
3-7: LGTM! Alt text properly internationalized.The alt text binding correctly references the translation key, and the past typo issue has been addressed.
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue (1)
70-78: LGTM! Empty state indicator properly internationalized.The title attribute correctly uses i18n binding for the "No items" tooltip, improving accessibility for non-English users.
src/platform/assets/components/AssetGrid.vue (1)
2-10: LGTM! ARIA label properly internationalized.The aria-label binding correctly uses i18n, ensuring screen reader users in different locales receive properly translated grid labels.
src/platform/cloud/onboarding/CloudSurveyView.vue (5)
44-52: LGTM! Button labels properly internationalized.The "Next" button label correctly uses the i18n binding
$t('g.next').
94-107: LGTM! Navigation buttons properly internationalized.The "Back" and "Next" button labels correctly use i18n bindings.
138-146: LGTM! Placeholder uses i18n binding.The
industryOtherplaceholder correctly uses the i18n key, though see earlier comment about potential key path improvement for theuseCaseOtherfield.
149-162: LGTM! Navigation buttons properly internationalized.The "Back" and "Next" button labels correctly use i18n bindings.
194-208: LGTM! Final step buttons properly internationalized.The "Back" and "Submit" button labels correctly use i18n bindings from the global namespace.
src/locales/en/main.json (7)
108-108: LGTM! Translation key added for submit button.The
submitkey properly supports the internationalization of submit buttons across the application.
238-249: LGTM! Multiple general-purpose translation keys added.The new keys (
playPause,beta,profile,noItems) provide appropriate translations for UI elements across the application.
696-696: LGTM! Preview label translation added.The
previewkey supports the queue progress overlay preview feature internationalization.
938-938: LGTM! Mask editor translation key added.The
stepSizekey properly supports the brush settings internationalization.
1844-1844: LGTM! Logo alt text translation added.The
comfyCloudLogokey supports accessible alt text for the Comfy Cloud logo.
2080-2080: LGTM! Asset browser translation key added.The
assetCollectionkey supports ARIA label internationalization for the asset grid.
2131-2133: LGTM! Asset browser filter translation keys added.The new keys (
selectFrameworks,selectProjects,sortingType) support internationalization of asset browser filtering options.
Summary
Catch more user visible (or audible) text that isn't internationalizable.
Changes
Review Focus
What other properties have leaked English text to non-English locales that aren't in here?