feat: show legacy manager search tip in no-results empty state#8537
Merged
christian-byrne merged 1 commit intomainfrom Feb 2, 2026
Merged
feat: show legacy manager search tip in no-results empty state#8537christian-byrne merged 1 commit intomainfrom
christian-byrne merged 1 commit intomainfrom
Conversation
christian-byrne
requested review from
a team,
ltdrdata and
viva-jinyi
as code owners
dosubot
bot
added
the
size:L
|
Related Documentation No published documentation to review for changes on this repository. Write your first living document How did I do? Any feedback? |
Contributor
📝 WalkthroughWalkthroughAdds a new localization string and a Vue composable to detect manager-related search queries when the new manager UI is active; integrates the composable into ManagerDialog so the empty-state search message includes the legacy-manager tip when appropriate; includes unit tests for the composable. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ManagerDialog
participant useLegacySearchTip as LegacyTip
participant ManagerState as State
participant I18n as Locales
User->>ManagerDialog: types searchQuery
ManagerDialog->>State: read isNewManagerUI
ManagerDialog->>LegacyTip: provide searchQuery, isNewManagerUI
LegacyTip-->>ManagerDialog: isLegacyManagerSearch (true/false)
ManagerDialog->>I18n: request base emptyStateMessage
I18n-->>ManagerDialog: base message
alt isLegacyManagerSearch == true
ManagerDialog->>I18n: request manager.legacyManagerSearchTip
I18n-->>ManagerDialog: legacy tip text
ManagerDialog-->>User: empty-state message + legacy tip
else
ManagerDialog-->>User: empty-state message
end
Possibly related PRs
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 02/02/2026, 01:11:00 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Tests:
|
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 26 kB (baseline 26 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 978 kB (baseline 978 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 471 kB (baseline 471 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 12 added / 12 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.89 kB (baseline 2.89 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 33.7 kB (baseline 33.7 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 2.71 MB (baseline 2.71 MB) • 🔴 +891 BStores, services, APIs, and repositories
Status: 8 added / 8 removed Utilities & Hooks — 25.3 kB (baseline 25.3 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 7 added / 7 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.16 MB (baseline 7.16 MB) • 🔴 +159 BBundles that do not match a named category
Status: 38 added / 38 removed |
Add non-intrusive tip in the no-results message when users search for legacy manager-related terms like 'manager', 'comfyui-manager', etc. - Create useLegacySearchTip composable to detect legacy manager searches - Integrate tip into emptyStateMessage as secondary muted text - Only shows when isNewManagerUI is true and no results found - Includes --enable-manager-legacy-ui flag instructions - Includes 9 test cases for coverage Amp-Thread-ID: https://ampcode.com/threads/T-019c1b62-3677-74f9-973d-43a940c9f677
christian-byrne
force-pushed
the
manager/legacy-search-tip
branch
from
c0e019e to
398fad3
Compare
christian-byrne
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Show a non-intrusive tip in the no-results empty state when users search legacy manager-related terms in the new manager UI.
Changes
useLegacySearchTipcomposable that detects when search query matches legacy manager keywords ("manager", "comfyui-manager", etc.) and appends a tip to the empty state message suggesting the--enable-manager-legacy-uiflagReview Focus
Fixes COM-12509