feat: add ComfyUI-Manager v4 support and uv-compile unified dependency resolution#363
Merged
feat: add ComfyUI-Manager v4 support and uv-compile unified dependency resolution#363
Conversation
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #363 +/- ##
==========================================
+ Coverage 67.04% 70.94% +3.90%
==========================================
Files 33 33
Lines 3711 3931 +220
==========================================
+ Hits 2488 2789 +301
+ Misses 1223 1142 -81
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
c29f340 to
b7d0a07
Compare
Contributor
|
@ltdrdata hello! is this PR is ready to be reviewed? (sorry, I completely forgot about this PR) |
Member
Author
|
Oh… additional updates to support uv-compile are currently in progress. Since the changes are fairly extensive, I’m also validating them more thoroughly. Please wait a bit longer. |
e8a78ce to
a4212d6
Compare
8b55247 to
73e3aea
Compare
73e3aea to
a655999
Compare
Member
Author
|
For the E2E tests to function correctly, the |
Contributor
|
@ltdrdata can you rebase this PR on |
a655999 to
f364014
Compare
Member
Author
|
To resolve the E2E test failures in the Windows environment, it needs to be updated to manager v4.1b6. |
c2f8a34 to
1ea21a5
Compare
11bdc38 to
b803c72
Compare
This was referenced Mar 22, 2026
856cf0b to
767a226
Compare
… resolution Manager v4 is now installed as a pip package (via manager_requirements.txt) rather than being git-cloned into custom_nodes/. Breaking changes: - Remove --manager-url and --manager-commit options from comfy install. Users who need a custom Manager should use --skip-manager and install their own wheel into the workspace venv. New features: - Manager GUI mode system (disable, enable-gui, disable-gui, enable-legacy-gui) - --uv-compile/--no-uv-compile flag on 7 node commands for unified dep resolution - comfy node uv-sync standalone command - comfy manager uv-compile-default config command - comfy manager migrate-legacy for git-to-pip migration - comfy node update-cache command - Windows pipe deadlock fix (stderr background drain thread) Tests: - Comprehensive unit tests for cm_cli_util, Manager GUI, node commands - E2E tests for uv-compile with conflict detection packs
767a226 to
82e6744
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComfyUI-Manager v4 is now installed as a pip package (via `manager_requirements.txt`) rather than being git-cloned into `custom_nodes/`.
Requires: ComfyUI-Manager >= 4.1b8 (via `manager_requirements.txt` in ComfyUI)
Breaking Changes
Manager v4 is installed as a pip package from `manager_requirements.txt`, not git-cloned. These flags controlled which git repo/commit to clone, so they no longer apply.
Manager Subcommand Changes
`--uv-compile` Unified Dependency Resolution
Adds `--uv-compile/--no-uv-compile` flag to 7 custom node commands for Manager v4.1+ unified dependency resolution via `uv pip compile`.
Commands with `--uv-compile`:
`install`, `reinstall`, `update`, `fix`, `restore-snapshot`, `restore-dependencies`, `install-deps`
Standalone command: `comfy node uv-sync` — batch-resolve all installed custom node dependencies.
Flag resolution priority: explicit flag -> config default (`comfy manager uv-compile-default`) -> disabled
Mutual exclusivity: `--uv-compile` cannot be used with `--fast-deps` or `--no-deps`.
Bug Fixes
Cache Management
`comfy node update-cache` — force-fetch remote data and populate local Manager cache (blocking).
E2E Test Infrastructure
Test plan
Dependencies
This PR will work correctly once the following ComfyUI-side PR is merged, which updates `manager_requirements.txt` to require `comfyui-manager>=4.1b8`: