Run configureInstaller after WaitForCompletion in WithXYZPackageInstallation methods#761
Merged
aaronpowell merged 1 commit intoCommunityToolkit:mainfrom Jul 30, 2025
Merged
Conversation
This gives consumers a chance to cancel the wait if they don't want to wait.
Member
|
Would it not make more sense to introduce an overload like |
Contributor
Author
|
Either way, I think the As for introducing a new optional arg overload, that sort of feels like we're fighting the natural builder pattern, and hsould instead go for more of a fluent API: frontEnd.WithNpmPackageInstallation(x => x
.WithCi()
.WithoutWait()); |
aaronpowell
approved these changes
Jul 30, 2025
This was referenced Aug 4, 2025
Closed
This was referenced Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #760
Run
configureInstallerafterWaitForCompletionin theWithXYZPackageInstallationmethodsPR Checklist
Other information