Conversation
TheCodeTraveler
added
pending documentation
Collaborator
|
Thanks Shaun! This is good to go once we have a docs PR 🙌 |
Contributor
Author
Thanks. I haven't added tests for converters yet either but I will get onto that |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables developers to inherit from BaseBehavior and BaseConverter by removing restrictive constructors and adding comprehensive unit tests for the behavior functionality.
- Removed explicit private protected constructors from BaseBehavior and BaseConverter to allow inheritance.
- Introduced new unit tests and a MockBehavior implementation to verify attachment, detachment, and property change handling.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/CommunityToolkit.Maui.UnitTests/Behaviors/BaseBehaviorTests.cs | Added unit tests verifying behavior attachment, detachment, and property change propagation. |
| src/CommunityToolkit.Maui.UnitTests/Mocks/MockBehavior.cs | Added MockBehavior class to support testing with custom assertions on the view and property changes. |
| src/CommunityToolkit.Maui/Behaviors/BaseBehavior.shared.cs | Removed redundant private protected constructor to enable inheritance. |
| src/CommunityToolkit.Maui/Converters/BaseConverter.shared.cs | Removed redundant private protected constructor to enable inheritance. |
…' of github.com:CommunityToolkit/Maui into feature/sl-open-up-converters-and-behavior-base-classes
VladislavAntonyuk
previously approved these changes
Mar 20, 2025
TheCodeTraveler
approved these changes
Mar 21, 2025
bijington
deleted the
feature/sl-open-up-converters-and-behavior-base-classes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR opens up the ability to inherit from both
BaseBehaviorandBaseConverter. It includes unit testing to cover the functionality that we expose in order to make it safe to use.Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information