Fix ExpressionFunctions.ColorLerpRgb #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arlodotexe
added
bug
Arlodotexe
approved these changes
Jan 9, 2024
Member
Arlodotexe
left a comment
Arlodotexe
left a comment
There was a problem hiding this comment.
I've added some unit tests to confirm that the original code was bugged, and this change fixes it. Looks good, thank you!
|
Awesome |
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#303
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The app will be crashed if the code uses
ExpressionFunctions.ColorLerpRgb.What is the new behavior?
The app won't be crashed and the animation works as expected.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information