Support AccessibilityView in MetadataControl#4328
Merged
michael-hawker merged 1 commit intoCommunityToolkit:mainfrom Dec 16, 2021
Merged
Conversation
|
Thanks lyf6lyf for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Contributor
|
Try kicking off the CI build process again, to see if a 2nd try gets the unit tests to pass. I was able to get the unit tests to pass after a second pass, on my dev machine. |
XAML-Knight
approved these changes
Oct 28, 2021
Member
|
@vgromfeld want to take a look? |
vgromfeld
approved these changes
Dec 3, 2021
Arlodotexe
approved these changes
Dec 9, 2021
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4433
PR Type
What kind of change does this PR introduce?
Feature
What is the current behavior?
We can not change the
AutomationProperties.AccessibilityViewof the innerTextBlockof theMetadataControl, that causes some accessibility issue.What is the new behavior?
We can change it by setting
AutomationProperties.AccessibilityViewof theMetadataControlPR Checklist
Please check if your PR fulfills the following requirements:
Other information