Fix app domain unloading issue on .NET Framework#4386
Merged
Sergio0694 merged 1 commit intoCommunityToolkit:mainfrom Nov 18, 2021
Merged
Fix app domain unloading issue on .NET Framework#4386Sergio0694 merged 1 commit intoCommunityToolkit:mainfrom
Sergio0694 merged 1 commit intoCommunityToolkit:mainfrom
Conversation
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
azchohfi
approved these changes
Nov 18, 2021
XAML-Knight
approved these changes
Nov 18, 2021
Member
|
Shipped as part of 7.1.2, I don't see our milestone for that though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of CommunityToolkit/dotnet@e2b3361.
Didn't really see any other commits already in https://github.com/CommunityToolkit/dotnet that would meet the hotfix bar for 7.1.2, so I think it's just this one hotfix we need on top of the other stuff that's already here on
main, eg. the animation fix.Fixes
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The app domain cannot be loaded on .NET Framework when using
WeakReferenceMessenger.What is the new behavior?
Auto trimming is disabled when running on .NET Framework, which solves the issue.
PR Checklist
Please check if your PR fulfills the following requirements: