Ryken100/attached card shadow composition mask brush resize fix#4588
Merged
michael-hawker merged 3 commits intoCommunityToolkit:mainfrom Aug 26, 2022
Conversation
…e == CompositionGeometricClip
|
Thanks Ryken100 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Arlodotexe
approved these changes
Aug 15, 2022
michael-hawker
approved these changes
Aug 26, 2022
Member
michael-hawker
left a comment
There was a problem hiding this comment.
Tested in the sample app, worked like a charm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4587
This PR fixes an issue where when
AttachedCardShadow.InnerContentClipTypeis set toCompositionMaskBrush, the shadow doesn't properly resize when the element it's attached to changes size. It also fixes an issue where ifInnerContentClipTypeis set toCompositionMaskBrushthen back toCompositionGeometricClip, resizing gets broken in theCompositionGeometricClipmode as well.PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
When
AttachedCardShadow.InnerContentClipType == CompositionMaskBrush, the sizes of the maskedSpriteVisual, and theSpriteVisualthat owns the shadow were not updated when the attachedFrameworkElementchanges size. Additionally,AttachedShadowElementContext.SpriteVisual.SizeandRelativeSizeAdjustmentvalues were not reset to default whenInnerContentClipTypechanged fromCompositionMaskBrushtoCompositionGeometricClip.What is the new behavior?
When
AttachedCardShadow.InnerContentClipType == CompositionMaskBrush, the sizes of the maskedSpriteVisual, and theSpriteVisualare now updated when the attachedFrameworkElementchanges size. Additionally,AttachedShadowElementContext.SpriteVisual.SizeandRelativeSizeAdjustmentare reset to default whenAttachedCardShadow.InnerContentClipType == CompositionGeometricClip, preventing potential resize issues.PR Checklist
Please check if your PR fulfills the following requirements:
Other information