Add null check for ListDetailsView.OnListPaneWidthChanged#4817
Add null check for ListDetailsView.OnListPaneWidthChanged#4817nodew wants to merge 1 commit intoCommunityToolkit:rel/winui/7.1.2from
Conversation
|
Thanks nodew for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
|
|
1 similar comment
|
|
|
@michael-hawker @azchohfi Could you please help review the changes? |
|
@nodew see message here: #4800 (reply in thread)
Our plan is to fix everything forward for 8.0 as we bring things over to our maintainable infrastructure. |
|
@michael-hawker Good to know that, thanks for the information. |
Fixes
When I try to use the ListPaneWidth of ListDetailsView with WinUI3/WindowsAppSDK, I got the same error described in #4357
It seems that the fix #4738 only fixed the issue in UWP and missed WinUI3
PR Type
What kind of change does this PR introduce?
Bugfix
Refactoring
What is the current behavior?
_TwoPaneViewpassed without checking for nullWhat is the new behavior?
It will check if
_twoPaneViewis null, and set value to_twoPaneView.Pane1Lengthonly when it's not null.PR Checklist
Please check if your PR fulfills the following requirements:
Other information