Update Renovate Autodiscover PoC to Run Arbitrary Commands Again#534
Merged
Update Renovate Autodiscover PoC to Run Arbitrary Commands Again#534
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Pipeleek’s Renovate autodiscovery PoC to use the Maven wrapper (mvnw) instead of the Gradle wrapper (gradlew), aligning with Renovate’s newer restrictions while keeping the PoC functional across GitLab/GitHub.
Changes:
- Replaced Gradle-based PoC artifacts (
build.gradle,gradlew,gradle-wrapper.properties) with Maven equivalents (pom.xml,mvnw,maven-wrapper.properties). - Updated GitLab/GitHub generator implementations plus unit/e2e tests to match the new Maven wrapper approach.
- Updated Renovate guide documentation and PoC logging expectations.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/gitlab/renovate/renovate_test.go | Updates assertions to expect Maven wrapper messaging (mvnw). |
| tests/e2e/github/renovate/renovate_test.go | Updates mock API and assertions for pom.xml + Maven wrapper messaging. |
| pkg/renovate/autodiscovery.go | Swaps shared PoC templates to Maven wrapper artifacts; adds Renovate PR throttling config. |
| pkg/gitlab/renovate/autodiscovery/autodiscovery_test.go | Updates unit tests to validate new Maven templates and generated files. |
| pkg/gitlab/renovate/autodiscovery/autodiscovery.go | Generates pom.xml, mvnw, and .mvn/wrapper/maven-wrapper.properties for GitLab PoC. |
| pkg/github/renovate/autodiscovery/autodiscovery.go | Generates pom.xml, mvnw, and .mvn/wrapper/maven-wrapper.properties for GitHub PoC. |
| internal/cmd/gitlab/renovate/autodiscovery/autodiscovery.go | Updates command help text to Maven wrapper; relaxes required config keys. |
| internal/cmd/github/renovate/autodiscovery/autodiscovery.go | Updates command help text to Maven wrapper; relaxes required config keys. |
| docs/guides/renovate.md | Updates example output and explanation to Maven wrapper flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate introduced renovatebot/renovate#39458 which disallows gradlew by default. However the mavenw is still allowed, migrate to this appoach.