This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Open
Conversation
MicaiahReid
requested review from
davidmurdoch,
jeffsmale90,
kevinbluer and
tenthirtyone
MicaiahReid
commented
Jul 1, 2022
| ## Using MetaMask with Ganache v7 | ||
|
|
||
| Using MetaMask with Ganache CLI is also very similar to that of Ganache. The only difference is that Ganache CLI runs by default on `http://127.0.0.1:8545` so you'll want to edit the above web3 code to say: | ||
| Using MetaMask with Ganache v7 is also very similar to that of Ganache. The only difference is that Ganache v7 runs by default on `http://127.0.0.1:8545` so you'll want to edit the above web3 code to say: |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| Using MetaMask with Ganache v7 is also very similar to that of Ganache. The only difference is that Ganache v7 runs by default on `http://127.0.0.1:8545` so you'll want to edit the above web3 code to say: | |
| Using MetaMask with Ganache v7 is also very similar to that of Ganache UI. The only difference is that Ganache v7 runs by default on `http://127.0.0.1:8545` so you'll want to edit the above web3 code to say: |
davidmurdoch
suggested changes
Aug 4, 2022
Contributor
davidmurdoch
left a comment
davidmurdoch
left a comment
There was a problem hiding this comment.
I'm not sure I'm comfortable with "Ganache v7" being a proper noun.
tenthirtyone
approved these changes
Aug 17, 2022
tenthirtyone
left a comment
tenthirtyone
left a comment
There was a problem hiding this comment.
Just a q: Would Ganache always imply latest version? I understand why you are explicit, e.g. Ganache UI and Ganache just doesn't sound right.
I am comfortable with what you and @davidmurdoch decide about the nomenclature, links/changes look good.
👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes references to Ganache CLI and adds references to Ganache v7.
This does not remove references to Ganache CLI in any blog posts or in the drizzle and filecoin docs. I am unfamiliar with drizzle and the filecoin Ganache flavor and didn't want to change anything without knowing it was accurate.
Fixes 3152