Add STARK curve#299
Merged
Merged
Conversation
gbotrel
approved these changes
Jan 9, 2023
Collaborator
gbotrel
left a comment
There was a problem hiding this comment.
lgtm 👍
on the TODOs:
- addchain works OK with fp. Not fr, I think it's a small bug in
addchainbut need to write a minimal reproductible test case... (it finds the addition chain for the legendre exponent, but the code generation template fails) - field arithmetic: since q0 == 1, q1 == 0, q2 == 0, many functions can be optimized, but the arithmetic templates are dirty and need some refactoring to allow that cleanly. Probably couple of days work and a good double digit perf boost on the fp.Mul (and consequently all the ecc ops cc @joshklop @omerfirmak )
Contributor
Pedersen is still the main bottleneck in our application, so that would be much appreciated if you can find the time. Thank you for all the work so far! |
Collaborator
Author
|
Let's merge this and track the field arithmetic optimization in #302 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports only Fp, Fr and G1 arithmetics.
TODO:
NewField()set with false flag)a!=0(but not sure we'll add another curve witha!=0)