Repository navigation
Conversation
…ot inside an emoji
kevin9327
requested review from
MikeRyanDev,
davidmckayv,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
October 31, 2026 03:25
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Two cuts in
server/src/plugins/mcp.tsstill sliced by UTF-16 units:resourceLinkTextbounds a resource_link's title, name and description to 400 withvalue.slice(0, 400) + "…".trimmedbounds the reason a vendor gives in a refused (403) request to 400 the same way.When the cut landed between the two halves of an emoji, the text ended in a lone high surrogate, so the Bot (or the operator reading the refusal) was handed
�…, a character that was never in the source.Both now use
cutAtCodeUnitsfromchannels/text.ts, whichresultText's own 20,000-character cut in the same file already uses. It drops the half character, so nothing gets longer than before.Where it runs
Boundary and audit
Changelog
CHANGELOG.mdunderUnreleased; happy to rebase if it conflicts.Proof
New case in
server/tests/mcp-result.test.ts(a description of 399 characters followed by emoji). On unmodifiedmain:With the change,
bun test tests/mcp-result.test.tspasses (25 pass).vendorFailure's 403 path has no direct test hook, sotrimmedis covered by the same helper rather than a new test.biome formatandbiome lint --error-on-warningson the changed files are clean.AI assistance: I used an AI coding assistant to find and write this change, and reviewed and tested it myself.