Skip to content

Implement vm heap#361

Open
AgwaB wants to merge 1 commit intoDE-labtory:0.2.0from
AgwaB:0.2.0
Open

Implement vm heap#361
AgwaB wants to merge 1 commit intoDE-labtory:0.2.0from
AgwaB:0.2.0

Conversation

@AgwaB
Copy link
Collaborator

@AgwaB AgwaB commented Mar 3, 2019 •
edited
Loading

details:

Implement vm heap

  • Test case

hihiboss
hihiboss reviewed Mar 3, 2019
View reviewed changes
Copy link
Member

@hihiboss hihiboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Free() necessary?

vm/heap.go
}
}

func (h *Heap) Set(id Hid, value Hvalue) {
Copy link
Member

@hihiboss hihiboss Mar 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about Store, not Set?

@junbeomlee
Copy link
Member

junbeomlee commented Mar 3, 2019

How about HAddress, Hdata?

This was referenced Mar 3, 2019
Open
Open
@zeroFruit
Copy link
Member

zeroFruit commented Mar 4, 2019

How about HAddress, Hdata?

HData?

@AgwaB
Copy link
Collaborator Author

AgwaB commented Mar 4, 2019

@hihiboss you mean free method exists to optimize?

@AgwaB
Copy link
Collaborator Author

AgwaB commented Mar 4, 2019

@junbeomlee good!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hihiboss hihiboss hihiboss left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AgwaB @junbeomlee @zeroFruit @hihiboss